From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758146AbcHWOqz (ORCPT ); Tue, 23 Aug 2016 10:46:55 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:42404 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757700AbcHWOqx (ORCPT ); Tue, 23 Aug 2016 10:46:53 -0400 Date: Tue, 23 Aug 2016 10:47:01 -0400 From: Greg Kroah-Hartman To: Miklos Szeredi Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Al Viro , Alexei Starovoitov Subject: Re: [PATCH 3/7] libfs: support RENAME_NOREPLACE in simple_rename() Message-ID: <20160823144701.GA9798@kroah.com> References: <1471961132-1675-1-git-send-email-mszeredi@redhat.com> <1471961132-1675-4-git-send-email-mszeredi@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1471961132-1675-4-git-send-email-mszeredi@redhat.com> User-Agent: Mutt/1.7.0 (2016-08-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 23, 2016 at 04:05:28PM +0200, Miklos Szeredi wrote: > This is trivial to do: > > - add flags argument to simple_rename() > - check if flags doesn't have any other than RENAME_NOREPLACE > - assign simple_rename() to .rename2 instead of .rename > > Filesystems converted: > > hugetlbfs, ramfs, bpf. > > Debugfs uses simple_rename() to implement debugfs_rename(), which is for > debugfs instances to rename files internally, not for userspace filesystem > access. For this case pass zero flags to simple_rename(). > > Signed-off-by: Miklos Szeredi > Cc: Alexei Starovoitov > Cc: Greg Kroah-Hartman Acked-by: Greg Kroah-Hartman