From: Alexey Dobriyan <adobriyan@gmail.com>
To: "Levin, Alexander" <alexander.levin@verizon.com>
Cc: Joe Perches <joe@perches.com>,
"ksummit-discuss@lists.linuxfoundation.org"
<ksummit-discuss@lists.linuxfoundation.org>,
Greg KH <gregkh@linuxfoundation.org>,
Sasha Levin <levinsasha928@gmail.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Ksummit-discuss] checkkpatch (in)sanity ?
Date: Sun, 28 Aug 2016 10:56:33 +0300 [thread overview]
Message-ID: <20160828075632.GA1852@p183.telecom.by> (raw)
In-Reply-To: <20160828005636.GB19088@sasha-lappy>
On Sat, Aug 27, 2016 at 09:06:13PM -0400, Levin, Alexander via Ksummit-discuss wrote:
> 3. This one is somewhat subjective: scripts/checkpatch.pl is a massive blob of
> perl code that a fair amount of people don't know how to deal with. In 4.8 it's
> 6142 lines, making it the 124th largest source file in the kernel, well within
> the top 1% of source files in the kernel.
>
> This combination of size/language pushes people away from being involved in
> what is supposed to be a central tool and gives them a reason to never use
> it again after they see results they don't agree with (rather than fixing it).
It is a textbook example of what's wrong with Perl. Instead of parsing
C code like compilers do, the script is one big pile of regexes.
It mostly works ("doing its job" in perlspeak) because people mostly
follow the coding style.
Regarding individual warnings: some are good (RETURN_VOID, DATE_TIME,
USE_NEGATIVE_ERRNO), some are OK given kernel style of allocating memory
but the rationale is bogus (UNNECESSARY_CASTS, linking to userspace
example of malloc() returning "int"!).
And then there is ALLOC_SIZEOF_STRUCT which advocates "kmalloc(sizeof(*p))".
The problem is that c-h.pl generates noise in the commit history and
makes git-blame less useful than it can be.
I for one given up on it more or less since its introduction.
next prev parent reply other threads:[~2016-08-28 7:56 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-27 20:40 checkkpatch (in)sanity ? Joe Perches
2016-08-28 1:06 ` Levin, Alexander
2016-08-28 1:42 ` Joe Perches
2016-08-28 2:20 ` Joe Perches
2016-08-28 2:47 ` Levin, Alexander
2016-08-28 17:15 ` Joe Perches
2016-08-28 17:59 ` Greg KH
2016-08-28 22:37 ` Levin, Alexander
2016-08-28 23:20 ` Joe Perches
2016-08-29 2:22 ` Levin, Alexander
2016-08-29 8:20 ` Christoph Hellwig
2016-08-29 7:15 ` [Ksummit-discuss] " Alexandre Belloni
2016-08-29 9:01 ` Arnd Bergmann
2016-08-29 12:47 ` Joe Perches
2016-08-29 17:16 ` Josh Triplett
2016-08-29 17:41 ` Joe Perches
2016-08-29 17:46 ` Luck, Tony
2016-08-29 18:01 ` Joe Perches
2016-08-29 18:47 ` Joe Perches
2016-08-29 19:08 ` Josh Triplett
2016-08-29 21:07 ` Arnd Bergmann
2016-08-29 11:15 ` Kalle Valo
2016-08-29 12:30 ` Joe Perches
2016-08-29 18:01 ` Kalle Valo
2016-08-29 19:00 ` Joe Perches
2016-08-29 21:00 ` [Ksummit-discuss] " Arnd Bergmann
2016-08-28 7:56 ` Alexey Dobriyan [this message]
2016-08-28 9:59 ` Julia Lawall
2016-08-28 19:52 ` Joe Perches
2016-08-28 20:35 ` Jiri Kosina
2016-08-28 21:24 ` Dennis Kaarsemaker
2016-08-28 21:57 ` Joe Perches
2016-08-29 19:06 ` Dan Carpenter
2016-08-29 19:10 ` Josh Triplett
2016-08-29 19:17 ` Dan Carpenter
2016-08-29 19:34 ` Joe Perches
2016-08-29 19:21 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160828075632.GA1852@p183.telecom.by \
--to=adobriyan@gmail.com \
--cc=alexander.levin@verizon.com \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=ksummit-discuss@lists.linuxfoundation.org \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).