From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755656AbcH2TRi (ORCPT ); Mon, 29 Aug 2016 15:17:38 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:46764 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751950AbcH2TRh (ORCPT ); Mon, 29 Aug 2016 15:17:37 -0400 Date: Mon, 29 Aug 2016 22:17:01 +0300 From: Dan Carpenter To: Josh Triplett Cc: Joe Perches , ksummit-discuss@lists.linuxfoundation.org, Greg KH , Sasha Levin , LKML Subject: Re: [Ksummit-discuss] checkkpatch (in)sanity ? Message-ID: <20160829191701.GL4129@mwanda> References: <1472330452.26978.23.camel@perches.com> <20160829190618.GF4180@mwanda> <20160829191020.GB27600@cloud> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160829191020.GB27600@cloud> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 29, 2016 at 12:10:20PM -0700, Josh Triplett wrote: > On Mon, Aug 29, 2016 at 10:06:18PM +0300, Dan Carpenter wrote: > > I would like a couple changes which you know already: > > > > 1) Get rid of PREFER_ETHER_ADDR_COPY and similar because the people who > > send checkpatch.pl fixes aren't qualified to say when it's legal or not > > so they sometimes introduce bugs. > > I do think we should have *something* that catches such things. > Perhaps not checkpatch.pl, though. Perhaps a compiler plugin that > generates additional warnings, and can perhaps use more global > information to determine legality? Perhaps. But that shouldn't delay us from deleting this code which just encourages newbies to introduce bugs. regards, dan carpenter