From: Pavel Machek <pavel@ucw.cz>
To: Rob Herring <robh@kernel.org>
Cc: ivo.g.dimitrov.75@gmail.com, sakari.ailus@iki.fi, sre@kernel.org,
pali.rohar@gmail.com, linux-media@vger.kernel.org,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
mchehab@osg.samsung.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] media: et8ek8: add device tree binding documentation
Date: Thu, 3 Nov 2016 13:47:49 +0100 [thread overview]
Message-ID: <20161103124749.GA22180@amd> (raw)
In-Reply-To: <20161030204134.hpmfrnqhd4mg563o@rob-hp-laptop>
[-- Attachment #1: Type: text/plain, Size: 1051 bytes --]
Hi!
> > +Mandatory properties
> > +--------------------
> > +
> > +- compatible: "toshiba,et8ek8"
> > +- reg: I2C address (0x3e, or an alternative address)
> > +- vana-supply: Analogue voltage supply (VANA), 2.8 volts
> > +- clocks: External clock to the sensor
> > +- clock-frequency: Frequency of the external clock to the sensor. Camera
> > + driver will set this frequency on the external clock.
>
> This is fine if the frequency is fixed (e.g. an oscillator), but you
> should use the clock binding if clocks are programable.
It is fixed. So I assume this can stay as is? Or do you want me to add
"The clock frequency is a pre-determined frequency known to be
suitable to the board." as Sakari suggests?
> > +- reset-gpios: XSHUTDOWN GPIO
>
> Please state what the active polarity is.
As in "This gpio will be set to 1 when the chip is powered." ?
Thanks,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2016-11-03 12:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-23 19:17 [PATCH v4] media: et8ek8: add device tree binding documentation Pavel Machek
2016-10-23 20:06 ` Sakari Ailus
2016-10-30 20:41 ` Rob Herring
2016-10-31 22:47 ` Sakari Ailus
2016-11-03 12:47 ` Pavel Machek [this message]
2016-11-03 22:20 ` Sakari Ailus
2016-11-07 10:36 ` Pavel Machek
2016-11-07 10:46 ` [PATCH v5] " Pavel Machek
2016-11-11 12:17 ` Pavel Machek
2016-11-14 16:20 ` Rob Herring
2016-11-14 18:30 ` [PATCH v6] " Pavel Machek
2016-11-14 18:39 ` Rob Herring
2016-12-20 13:05 ` Sakari Ailus
2016-12-21 13:20 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161103124749.GA22180@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mchehab@osg.samsung.com \
--cc=pali.rohar@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).