From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Christian Steiner <christian.steiner@outlook.de>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] pinctrl: cherryview: Serialize register access in suspend and resume hooks
Date: Fri, 4 Nov 2016 17:28:21 +0200 [thread overview]
Message-ID: <20161104152821.GS1436@lahna.fi.intel.com> (raw)
In-Reply-To: <CACRpkdbgvVzv0YVmt7CQ6uwnsAtLnNoFJs6a8vopngb6CQVFqQ@mail.gmail.com>
On Fri, Nov 04, 2016 at 04:15:59PM +0100, Linus Walleij wrote:
> On Fri, Nov 4, 2016 at 4:12 PM, Linus Walleij <linus.walleij@linaro.org> wrote:
> > On Mon, Oct 31, 2016 at 3:57 PM, Mika Westerberg
> > <mika.westerberg@linux.intel.com> wrote:
> >
> >> If async suspend is enabled, the driver may access registers concurrently
> >> with another instance which may fail because of the bug in Cherryview GPIO
> >> hardware. Prevent this by taking the shared lock while accessing the
> >> hardware in suspend and resume hooks.
> >>
> >> Signed-off-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> >
> > Patch applied.
>
> Mika should this and patch 2/3 be tagged for stable?
Yes, I think they should.
prev parent reply other threads:[~2016-11-04 15:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-31 14:57 [PATCH 1/3] pinctrl: cherryview: Serialize register access in suspend and resume hooks Mika Westerberg
2016-10-31 14:57 ` [PATCH 2/3] pinctrl: cherryview: Prevent possible interrupt storm on resume Mika Westerberg
2016-11-04 15:14 ` Linus Walleij
2016-10-31 14:57 ` [PATCH 3/3] pinctrl: cherryview: Drop ctrlX prefix from the pin debugfs output Mika Westerberg
2016-11-04 15:15 ` Linus Walleij
2016-11-04 15:12 ` [PATCH 1/3] pinctrl: cherryview: Serialize register access in suspend and resume hooks Linus Walleij
2016-11-04 15:15 ` Linus Walleij
2016-11-04 15:28 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161104152821.GS1436@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=christian.steiner@outlook.de \
--cc=heikki.krogerus@linux.intel.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).