From: Thierry Reding <thierry.reding@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Stephen Warren <swarren@wwwdotorg.org>,
Alexandre Courbot <gnurou@gmail.com>,
Jon Hunter <jonathanh@nvidia.com>,
Mirza Krak <mirza.krak@gmail.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] bus: tegra-gmi: fix build error
Date: Tue, 8 Nov 2016 16:45:04 +0100 [thread overview]
Message-ID: <20161108154504.GB2244@ulmo.ba.sec> (raw)
In-Reply-To: <20161108135058.1991567-1-arnd@arndb.de>
[-- Attachment #1: Type: text/plain, Size: 850 bytes --]
On Tue, Nov 08, 2016 at 02:50:29PM +0100, Arnd Bergmann wrote:
> The newly added driver fails to build right away:
>
> drivers/bus/tegra-gmi.c: In function 'tegra_gmi_parse_dt':
> drivers/bus/tegra-gmi.c:97:11: error: 'dev' undeclared (first use in this function)
>
> I guess a last-minute change removed a local variable, this
> adds the obvious definiton.
>
> Fixes: 4f95e6a5c9e4 ("bus: Add support for Tegra Generic Memory Interface")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/bus/tegra-gmi.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
This got reported by the 0-day builder earlier. Turns out this slipped
through because my build setup failed to pick up the new configuration
option. I pushed a fix for this to the Tegra tree, so it should all be
good by tomorrow.
Thanks,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
prev parent reply other threads:[~2016-11-08 15:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 13:50 [PATCH] bus: tegra-gmi: fix build error Arnd Bergmann
2016-11-08 15:45 ` Thierry Reding [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161108154504.GB2244@ulmo.ba.sec \
--to=thierry.reding@gmail.com \
--cc=arnd@arndb.de \
--cc=gnurou@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mirza.krak@gmail.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).