From: Stephen Boyd <sboyd@codeaurora.org>
To: Sarangdhar Joshi <spjoshi@codeaurora.org>
Cc: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
linux-arm-msm@vger.kernel.org, linux-soc@vger.kernel.org,
linux-kernel@vger.kernel.org,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Jordan Crouse <jcrouse@codeaurora.org>,
Trilok Soni <tsoni@codeaurora.org>
Subject: Re: [PATCH v2 3/3] firmware: qcom: scm: Return PTR_ERR when devm_clk_get fails
Date: Wed, 9 Nov 2016 17:49:08 -0800 [thread overview]
Message-ID: <20161110014908.GZ16026@codeaurora.org> (raw)
In-Reply-To: <1478218237-1737-4-git-send-email-spjoshi@codeaurora.org>
On 11/03, Sarangdhar Joshi wrote:
> When devm_clk_get fails for core clock, the failure was ignored
> and the core_clk was explicitly set to NULL so that other
> remaining clocks can be queried. However, now that we have a
> cleaner way of expressing the clock dependency, return failure
> when devm_clk_get fails for core clock.
>
> Signed-off-by: Sarangdhar Joshi <spjoshi@codeaurora.org>
Why can't this be folded into the second patch? It seems
incorrect to allow it to silently work in patch 2 even though
we've flagged that clk as a requirement and then change that
behavior here.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-11-10 1:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-04 0:10 [PATCH v2 0/3] Remove clocks dependency from SCM driver Sarangdhar Joshi
2016-11-04 0:10 ` [PATCH v2 1/3] dt-bindings: firmware: scm: Add MSM8996 DT bindings Sarangdhar Joshi
2016-11-10 1:49 ` Stephen Boyd
2016-11-04 0:10 ` [PATCH v2 2/3] firmware: qcom: scm: Remove core, iface and bus clocks dependency Sarangdhar Joshi
2016-11-10 1:47 ` Stephen Boyd
2016-11-10 5:55 ` Bjorn Andersson
2016-11-10 23:17 ` Stephen Boyd
2016-11-11 22:07 ` Sarangdhar Joshi
2016-11-11 21:59 ` Sarangdhar Joshi
2016-11-04 0:10 ` [PATCH v2 3/3] firmware: qcom: scm: Return PTR_ERR when devm_clk_get fails Sarangdhar Joshi
2016-11-10 1:49 ` Stephen Boyd [this message]
2016-11-11 21:30 ` Sarangdhar Joshi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110014908.GZ16026@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=david.brown@linaro.org \
--cc=jcrouse@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
--cc=spjoshi@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).