From: Joerg Roedel <joro@8bytes.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
iommu@lists.linux-foundation.org,
linux-samsung-soc@vger.kernel.org,
Inki Dae <inki.dae@samsung.com>, Kukjin Kim <kgene@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Mark Brown <broonie@kernel.org>,
"Luis R. Rodriguez" <mcgrof@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tomeu Vizoso <tomeu.vizoso@collabora.com>,
Lukas Wunner <lukas@wunner.de>, Kevin Hilman <khilman@kernel.org>,
Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
Tomasz Figa <tomasz.figa@gmail.com>
Subject: Re: [PATCH v6 3/7] iommu/exynos: Simplify internal enable/disable functions
Date: Thu, 10 Nov 2016 17:40:03 +0100 [thread overview]
Message-ID: <20161110164003.GL2078@8bytes.org> (raw)
In-Reply-To: <1478611764-6473-4-git-send-email-m.szyprowski@samsung.com>
On Tue, Nov 08, 2016 at 02:29:20PM +0100, Marek Szyprowski wrote:
> Remove remaining leftovers of the ref-count related code in the
> __sysmmu_enable/disable functions inline __sysmmu_enable/disable_nocount
> to them. Suspend/resume callbacks now checks if master device is set for
> given SYSMMU controller instead of relying on the activation count.
>
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
> drivers/iommu/exynos-iommu.c | 104 ++++++++++++-------------------------------
> 1 file changed, 29 insertions(+), 75 deletions(-)
>
> diff --git a/drivers/iommu/exynos-iommu.c b/drivers/iommu/exynos-iommu.c
> index 4056228..f45b274 100644
> --- a/drivers/iommu/exynos-iommu.c
> +++ b/drivers/iommu/exynos-iommu.c
> @@ -237,8 +237,8 @@ struct sysmmu_drvdata {
> struct clk *aclk; /* SYSMMU's aclk clock */
> struct clk *pclk; /* SYSMMU's pclk clock */
> struct clk *clk_master; /* master's device clock */
> - int activations; /* number of calls to sysmmu_enable */
> spinlock_t lock; /* lock for modyfying state */
> + int active; /* current status */
Any reason for this being int and not bool? You only assign true/false
later.
Joerg
next prev parent reply other threads:[~2016-11-10 16:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20161108133014eucas1p2a5dd3306a464ee840e26532f6c405b66@eucas1p2.samsung.com>
2016-11-08 13:29 ` [PATCH v6 0/7] Exynos IOMMU: proper runtime PM support (use device dependencies) Marek Szyprowski
[not found] ` <CGME20161108133014eucas1p211e2f31b0091d22014c2a5940c3da1dd@eucas1p2.samsung.com>
2016-11-08 13:29 ` [PATCH v6 1/7] iommu/exynos: Remove excessive, useless debug Marek Szyprowski
[not found] ` <CGME20161108133015eucas1p234c8c7076bcda5020ae8b78e87a0203d@eucas1p2.samsung.com>
2016-11-08 13:29 ` [PATCH v6 2/7] iommu/exynos: Remove dead code Marek Szyprowski
[not found] ` <CGME20161108133016eucas1p27a25afd3a49bfc1e3e41c5a32e022f07@eucas1p2.samsung.com>
2016-11-08 13:29 ` [PATCH v6 3/7] iommu/exynos: Simplify internal enable/disable functions Marek Szyprowski
2016-11-10 16:40 ` Joerg Roedel [this message]
[not found] ` <CGME20161108133017eucas1p29e9dc833d57d4f7951d053dab8ba6bef@eucas1p2.samsung.com>
2016-11-08 13:29 ` [PATCH v6 4/7] iommu/exynos: Set master device once on boot Marek Szyprowski
[not found] ` <CGME20161108133017eucas1p28233851f230060cf91d31298bcf69e07@eucas1p2.samsung.com>
2016-11-08 13:29 ` [PATCH v6 5/7] iommu/exynos: Rework and fix internal locking Marek Szyprowski
[not found] ` <CGME20161108133018eucas1p27180e82ae25189bda573766251491e66@eucas1p2.samsung.com>
2016-11-08 13:29 ` [PATCH v6 6/7] iommu/exynos: Add runtime pm support Marek Szyprowski
[not found] ` <CGME20161108133019eucas1p1be275492ba670030324a164320866008@eucas1p1.samsung.com>
2016-11-08 13:29 ` [PATCH v6 7/7] iommu/exynos: Use device dependency links to control runtime pm Marek Szyprowski
2016-11-09 23:31 ` Luis R. Rodriguez
2016-11-09 23:42 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161110164003.GL2078@8bytes.org \
--to=joro@8bytes.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=inki.dae@samsung.com \
--cc=iommu@lists.linux-foundation.org \
--cc=kgene@kernel.org \
--cc=khilman@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=m.szyprowski@samsung.com \
--cc=mcgrof@kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tjakobi@math.uni-bielefeld.de \
--cc=tomasz.figa@gmail.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).