From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965144AbcKJR5Z (ORCPT ); Thu, 10 Nov 2016 12:57:25 -0500 Received: from mx2.suse.de ([195.135.220.15]:55684 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964977AbcKJR5W (ORCPT ); Thu, 10 Nov 2016 12:57:22 -0500 Date: Thu, 10 Nov 2016 18:57:18 +0100 From: Borislav Petkov To: Yazen Ghannam Cc: mingo@kernel.org, tglx@linutronix.de, hpa@zytor.com, linux-kernel@vger.kernel.org, linux-tip-commits@vger.kernel.org Subject: Re: [tip:ras/core] x86/RAS: Simplify SMCA HWID descriptor struct Message-ID: <20161110175718.urdewzh74bj4pstc@pd.tnic> References: <20161103125556.15482-2-bp@alien8.de> <20161110175004.lji5k53ccli7gjig@yaz-fedora.dyhomenet> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161110175004.lji5k53ccli7gjig@yaz-fedora.dyhomenet> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 10, 2016 at 12:50:04PM -0500, Yazen Ghannam wrote: > Adding extra parentheses in HWID_MCATYPE() gives the same assembly as the > original code and fixes the behavior. > > > + hwid_mcatype = HWID_MCATYPE((high & MCI_IPID_HWID)), > > + ((high & MCI_IPID_MCATYPE) >> 16)); Argh, the macro should be adding the additional parentheses: #define HWID_MCATYPE(hwid, mcatype) (((hwid) << 16) | (mcatype)) That should fix the issue too. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --