From: Alexandre Belloni <alexandre.belloni@free-electrons.com>
To: Emil Bartczak <emilbart@gmail.com>
Cc: a.zummo@towertech.it, rtc-linux@googlegroups.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] rtc: mcp795: fix month write resetting date to 1.
Date: Mon, 5 Dec 2016 23:47:33 +0100 [thread overview]
Message-ID: <20161205224733.rioq3c4icjjkrg4c@piout.net> (raw)
In-Reply-To: <20161205221655.GA15764@emba-laptop>
On 05/12/2016 at 23:16:55 +0100, Emil Bartczak wrote :
> > > +static int mcp795_start_oscillator(struct device *dev)
> > > +{
> > > + return mcp795_rtcc_set_bits(dev, MCP795_REG_SECONDS,
> > > + MCP795_ST_BIT, MCP795_ST_BIT);
> >
> > You probably want to restore EXTOSC to its previous value here.
> I came to the conclusion that it is better to remove clearing of bit EXTOSC in function mcp795_stop_oscillator.
> Because regarding datasheet, after power up the RTC chip (or reset) that bit has value 0.
> What do you think?
>
That is one way but maybe some people are setting that bit in the
bootloader. It doesn't matter much. If you are not using the feature,
let it that way. If anybody needs it at some point they can still send a
patch :)
--
Alexandre Belloni, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-12-05 22:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 13:11 [PATCH 0/4] Provides bug fixes for rtc-mcp795.c Emil Bartczak
2016-12-05 13:11 ` [PATCH 1/4] rtc: mcp795: fix invalid month setting Emil Bartczak
2016-12-05 15:09 ` Alexandre Belloni
2016-12-05 22:03 ` Emil Bartczak
2016-12-05 22:15 ` Alexandre Belloni
2016-12-05 22:31 ` Emil Bartczak
2016-12-05 13:11 ` [PATCH 2/4] rtc: mcp795: fix time range difference between linux and RTC chip Emil Bartczak
2016-12-05 13:11 ` [PATCH 3/4] rtc: mcp795: fix month write resetting date to 1 Emil Bartczak
2016-12-05 15:24 ` Alexandre Belloni
2016-12-05 22:16 ` Emil Bartczak
2016-12-05 22:47 ` Alexandre Belloni [this message]
2016-12-05 13:11 ` [PATCH 4/4] rtc: mcp795: use bcd2bin/bin2bcd Emil Bartczak
2016-12-05 15:27 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205224733.rioq3c4icjjkrg4c@piout.net \
--to=alexandre.belloni@free-electrons.com \
--cc=a.zummo@towertech.it \
--cc=emilbart@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).