From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757262AbcLPBOY (ORCPT ); Thu, 15 Dec 2016 20:14:24 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:45783 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754012AbcLPBOM (ORCPT ); Thu, 15 Dec 2016 20:14:12 -0500 X-ME-Sender: X-Sasl-enc: tU2l820D4HL76qdhz3W/npEXYd2Zj9tLCRiNCUML8cB0 1481850822 Date: Thu, 15 Dec 2016 18:13:41 -0700 From: Mark Greer To: Geoff Lansberry Cc: linux-wireless@vger.kernel.org, lauro.venancio@openbossa.org, aloisio.almeida@openbossa.org, sameo@linux.intel.com, robh+dt@kernel.org, mark.rutland@arm.com, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, justin@kuvee.com Subject: Re: [PATCH 2/3] NFC: trf7970a: Add device tree option of 1.8 Volt IO voltage Message-ID: <20161216011341.GB25227@animalcreek.com> References: <1481841044-4314-1-git-send-email-glansberry@gmail.com> <1481841044-4314-2-git-send-email-glansberry@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1481841044-4314-2-git-send-email-glansberry@gmail.com> Organization: Animal Creek Technologies, Inc. User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 15, 2016 at 05:30:43PM -0500, Geoff Lansberry wrote: > From: Geoff Lansberry Missing commit description. > diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c > index 2d2a077..b4c37ab 100644 > --- a/drivers/nfc/trf7970a.c > +++ b/drivers/nfc/trf7970a.c > @@ -1048,6 +1049,11 @@ static int trf7970a_init(struct trf7970a *trf) > if (ret) > goto err_out; > > + ret = trf7970a_write(trf, TRF7970A_REG_IO_CTRL, > + trf->io_ctrl|TRF7970A_REG_IO_CTRL_VRS(0x1)); s/l|T/l | T/ Otherwise, looks good. Mark --