From: Richard Cochran <richardcochran@gmail.com>
To: henrik@austad.us
Cc: linux-kernel@vger.kernel.org, Henrik Austad <haustad@cisco.com>,
linux-media@vger.kernel.org, alsa-devel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [TSN RFC v2 0/9] TSN driver for the kernel
Date: Fri, 16 Dec 2016 23:05:30 +0100 [thread overview]
Message-ID: <20161216220530.GA25258@netboy> (raw)
In-Reply-To: <1481911153-549-1-git-send-email-henrik@austad.us>
On Fri, Dec 16, 2016 at 06:59:04PM +0100, henrik@austad.us wrote:
> The driver is directed via ConfigFS as we need userspace to handle
> stream-reservation (MSRP), discovery and enumeration (IEEE 1722.1) and
> whatever other management is needed.
I complained about configfs before, but you didn't listen.
> 2 new fields in netdev_ops have been introduced, and the Intel
> igb-driver has been updated (as this an AVB-capable NIC which is
> available as a PCI-e card).
The igb hacks show that you are on the wrong track. We can and should
be able to support TSN without resorting to driver specific hacks and
module parameters.
> Before reading on - this is not even beta, but I'd really appreciate if
> people would comment on the overall architecture and perhaps provide
> some pointers to where I should improve/fix/update
As I said before about V1, this architecture stinks. You appear to
have continued hacking along and posted the same design again. Did
you even address any of the points I raised back then?
You are trying to put tons of code into the kernel that really belongs
in user space, and at the same time, you omit critical functions that
only the kernel can provide.
> There are at least one AVB-driver (the AV-part of TSN) in the kernel
> already.
And which driver is that?
Thanks,
Richard
next prev parent reply other threads:[~2016-12-16 22:05 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 17:59 [TSN RFC v2 0/9] TSN driver for the kernel henrik
2016-12-16 17:59 ` [TSN RFC v2 1/9] igb: add missing fields to TXDCTL-register henrik
2016-12-16 17:59 ` [TSN RFC v2 2/9] TSN: add documentation henrik
2016-12-16 17:59 ` [TSN RFC v2 3/9] TSN: Add the standard formerly known as AVB to the kernel henrik
2016-12-16 17:59 ` [TSN RFC v2 4/9] Adding TSN-driver to Intel I210 controller henrik
2016-12-16 17:59 ` [TSN RFC v2 5/9] Add TSN header for the driver henrik
2016-12-16 22:09 ` Richard Cochran
2016-12-17 8:53 ` Henrik Austad
2016-12-16 17:59 ` [TSN RFC v2 6/9] Add TSN machinery to drive the traffic from a shim over the network henrik
2016-12-16 17:59 ` [TSN RFC v2 7/9] Add TSN event-tracing henrik
2016-12-16 17:59 ` [TSN RFC v2 8/9] AVB ALSA - Add ALSA shim for TSN henrik
2016-12-16 17:59 ` [TSN RFC v2 9/9] MAINTAINERS: add TSN/AVB-entries henrik
2016-12-16 18:12 ` [TSN RFC v2 0/9] TSN driver for the kernel Greg
2016-12-16 18:20 ` David Miller
2016-12-16 19:07 ` Henrik Austad
2016-12-16 22:05 ` Richard Cochran [this message]
2016-12-17 9:05 ` Henrik Austad
2016-12-17 20:09 ` Richard Cochran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161216220530.GA25258@netboy \
--to=richardcochran@gmail.com \
--cc=alsa-devel@vger.kernel.org \
--cc=haustad@cisco.com \
--cc=henrik@austad.us \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).