From: Mark Brown <broonie@kernel.org>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Shrirang Bagul <shrirang.bagul@canonical.com>,
alsa-devel@alsa-project.org,
Jorge Fernandez Monteagudo <jorgefm@cirsa.com>,
Arnd Bergmann <arnd@arndb.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Vinod Koul <vinod.koul@intel.com>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Ramesh Babu <ramesh.babu@intel.com>,
Ben Zhang <benzh@chromium.org>, John Keeping <john@metanate.com>,
Sathyanarayana Nujella <sathyanarayana.nujella@intel.com>,
Colin Ian King <colin.king@canonical.com>,
Jeeja KP <jeeja.kp@intel.com>
Subject: Re: [alsa-devel] [PATCH 2/2] ASoC: Intel: boards: Add Baytrail RT5660 machine driver
Date: Mon, 19 Dec 2016 16:44:02 +0000 [thread overview]
Message-ID: <20161219164402.g4knszgpgowfxelb@sirena.org.uk> (raw)
In-Reply-To: <a712abe0-4fc0-8b7f-b819-2903564b88c6@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 631 bytes --]
On Mon, Dec 19, 2016 at 10:30:09AM -0600, Pierre-Louis Bossart wrote:
> All this code seems to be largely a copy-paste of the bytcr_rt5640 machine
> driver and the same comments would apply there. This patch did miss the last
Yes, there's a lot of room for cleanups in the existing code too (and of
course if there's such a large amount of cut'n'paste that implies that
there should be some code reuse going on).
> correction merged by Mark to deal with errors "ASoC: Intel: bytcr_rt5640:
> fallback mechanism if MCLK is not enabled" and the same error handling would
> be needed.
There was a cut back version of it I thought?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2016-12-19 16:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 13:51 [PATCH 0/2] ASoC: Dell IoT Gateway audio support Shrirang Bagul
2016-12-19 13:51 ` [PATCH 1/2] ASoC: rt5660: Add ACPI support Shrirang Bagul
2016-12-19 15:44 ` Mark Brown
2016-12-27 3:31 ` Shrirang Bagul
2016-12-19 13:51 ` [PATCH 2/2] ASoC: Intel: boards: Add Baytrail RT5660 machine driver Shrirang Bagul
2016-12-19 15:55 ` Mark Brown
2016-12-19 16:30 ` [alsa-devel] " Pierre-Louis Bossart
2016-12-19 16:44 ` Mark Brown [this message]
2016-12-27 3:29 ` Shrirang Bagul
2016-12-27 3:32 ` Shrirang Bagul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161219164402.g4knszgpgowfxelb@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=benzh@chromium.org \
--cc=colin.king@canonical.com \
--cc=jeeja.kp@intel.com \
--cc=john@metanate.com \
--cc=jorgefm@cirsa.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ramesh.babu@intel.com \
--cc=sathyanarayana.nujella@intel.com \
--cc=shrirang.bagul@canonical.com \
--cc=tiwai@suse.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).