From: Christoph Hellwig <hch@infradead.org>
To: Scott Bauer <sbauer@eng.utah.edu>
Cc: Christoph Hellwig <hch@infradead.org>,
Keith Busch <keith.busch@intel.com>,
axboe@fb.com, sagi@grimberg.me, Rafael.Antognolli@intel.com,
linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org,
Scott Bauer <scott.bauer@intel.com>,
jonathan.derrick@intel.com, viro@zeniv.linux.org.uk
Subject: Re: [PATCH v3 4/5] nvme: Implement resume_from_suspend and SED Allocation code.
Date: Wed, 21 Dec 2016 01:01:28 -0800 [thread overview]
Message-ID: <20161221090128.GA7048@infradead.org> (raw)
In-Reply-To: <aa3b337c-deeb-057d-1054-1443a43dbae4@eng.utah.edu>
On Tue, Dec 20, 2016 at 09:05:32AM -0700, Scott Bauer wrote:
> Thanks Keith. Although TCG Spec currently ignores it in the future it may not.
> In that case we should probably attempt to future proof it a bit. Since the
> namespace ID is accessible via the block device structure I'll find a way to
> include that in some opaque pointer that we can deliver through the core into
> NVMe.
Honestly I think this nsid issue is a major, major mess. Without a nsid
only the global range makes sense, and in that case it does not make
sense to set a nsid (so it should be 0xFFFFFFFF). This one more of the
major major issues because the NVMe group decided to not care about
security and outsourced it to that giant heap of crap called TCG.
I think we'll need to start a little conversation on the nvme list on
how to handle this, including potential errata.
> But this also brings up another question (and part of the reason I moved from
> the block ioctl to fs ioctl): For drives with multiple namsepaces is it
> acceptable to allow a namespace, who has a segregated chunk of space, the ability
> to perform actions outside of its range? Since the multiple namespaces portion
> of the spec says there will be one Global LR a namespace that doesn't encompass
> the entire LBA range can end up locking other LBAs via locking the global.
>
> That's why I wanted to go to char dev because it seemed like a better fit for
> this scenario. Any thoughts on the above?
In SCSI we allow all kinds of ioctls affecting target-wide behavior on
the device nodes. These needs to be protected using CAP_SYS_ADMIN,
otherwise we're going to get security issues, though (and in SCSI land
we had such issues before).
next prev parent reply other threads:[~2016-12-21 9:01 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 19:35 [PATCH v3 0/5] SED OPAL Library Scott Bauer
2016-12-19 19:35 ` [PATCH v3 1/5] include: Add definitions for sed Scott Bauer
2016-12-20 6:46 ` Christoph Hellwig
2016-12-25 14:15 ` Jethro Beekman
2016-12-27 22:14 ` Scott Bauer
2016-12-19 19:35 ` [PATCH v3 2/5] lib: Add Sed-opal library Scott Bauer
2016-12-19 21:34 ` Keith Busch
2016-12-20 6:07 ` Christoph Hellwig
2016-12-20 3:21 ` kbuild test robot
2016-12-20 3:48 ` kbuild test robot
2016-12-20 6:50 ` Al Viro
2016-12-20 7:28 ` Christoph Hellwig
2016-12-20 21:55 ` Scott Bauer
2016-12-21 9:42 ` Christoph Hellwig
2016-12-20 22:07 ` Jon Derrick
2016-12-21 9:47 ` Christoph Hellwig
2016-12-19 19:35 ` [PATCH v3 3/5] fs: Wire up SED/Opal to ioctl Scott Bauer
2016-12-20 6:21 ` Christoph Hellwig
2016-12-19 19:35 ` [PATCH v3 4/5] nvme: Implement resume_from_suspend and SED Allocation code Scott Bauer
2016-12-19 21:59 ` Keith Busch
2016-12-19 22:23 ` Scott Bauer
2016-12-20 6:17 ` Christoph Hellwig
2016-12-20 15:49 ` Keith Busch
2016-12-20 15:46 ` Christoph Hellwig
2016-12-20 16:05 ` Scott Bauer
2016-12-21 9:01 ` Christoph Hellwig [this message]
2016-12-20 17:52 ` Scott Bauer
2016-12-21 9:37 ` Christoph Hellwig
2016-12-20 4:11 ` kbuild test robot
2016-12-20 6:21 ` Christoph Hellwig
2016-12-20 6:49 ` Christoph Hellwig
2016-12-25 14:15 ` Jethro Beekman
2016-12-27 22:12 ` Scott Bauer
2016-12-28 8:39 ` Christoph Hellwig
2016-12-19 19:35 ` [PATCH v3 5/5] Maintainers: Add Information for SED Opal library Scott Bauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161221090128.GA7048@infradead.org \
--to=hch@infradead.org \
--cc=Rafael.Antognolli@intel.com \
--cc=axboe@fb.com \
--cc=jonathan.derrick@intel.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=sbauer@eng.utah.edu \
--cc=scott.bauer@intel.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).