From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Petr Mladek <pmladek@suse.com>, Jan Kara <jack@suse.cz>,
Tejun Heo <tj@kernel.org>, Calvin Owens <calvinowens@fb.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Andy Lutomirski <luto@kernel.org>,
Peter Hurley <peter@hurleysoftware.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCHv6 2/7] printk: rename nmi.c and exported api
Date: Thu, 22 Dec 2016 10:17:22 +0900 [thread overview]
Message-ID: <20161222011722.GA644@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <CA+55aFyU-XvPqiPAFjetK6Sn8GUqnX0zjLKu=fd317Cxz4KwSw@mail.gmail.com>
On (12/21/16 11:45), Linus Torvalds wrote:
> On Wed, Dec 21, 2016 at 6:36 AM, Sergey Senozhatsky
> <sergey.senozhatsky@gmail.com> wrote:
> > A preparation patch for printk_safe work. No functional change.
> > - rename nmi.c to print_safe.c
> > - rename exported functions to have a `printk_safe' prefix.
>
> I dislike this patch.
>
> It's _mostly_ ok, but the nmi naming is nasty.
ok, will change. Petr complained about the nmi naming as well.
-ss
> Either "printk_nmi()" or "printk_safe" is fine, but doing *both* is
> stupid and wrong. And you do both in a couple of places.
>
> So please keep the printk_nmi_enter/exit() naming. Because
> "printk_safe_nmi_enter/exit()" is just stupid. It's about nmi entry.
> The "safe" part is simply an implementation detail.
>
> Linus
>
next prev parent reply other threads:[~2016-12-22 1:17 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 14:35 [PATCHv6 0/7] printk: use printk_safe to handle printk() recursive calls Sergey Senozhatsky
2016-12-21 14:35 ` [PATCHv6 1/7] printk: use vprintk_func in vprintk() Sergey Senozhatsky
2016-12-21 14:36 ` [PATCHv6 2/7] printk: rename nmi.c and exported api Sergey Senozhatsky
2016-12-21 19:45 ` Linus Torvalds
2016-12-22 1:17 ` Sergey Senozhatsky [this message]
2016-12-21 14:36 ` [PATCHv6 3/7] printk: introduce per-cpu safe_print seq buffer Sergey Senozhatsky
2016-12-22 0:53 ` kbuild test robot
2016-12-22 1:18 ` Sergey Senozhatsky
2016-12-22 16:36 ` Petr Mladek
2016-12-21 14:36 ` [PATCHv6 4/7] printk: always use deferred printk when flush printk_safe lines Sergey Senozhatsky
2016-12-21 14:36 ` [PATCHv6 5/7] printk: report lost messages in printk safe/nmi contexts Sergey Senozhatsky
2016-12-23 10:54 ` Petr Mladek
2016-12-23 15:08 ` Sergey Senozhatsky
2016-12-21 14:36 ` [PATCHv6 6/7] printk: use printk_safe buffers in printk Sergey Senozhatsky
2016-12-22 5:31 ` Sergey Senozhatsky
2016-12-22 17:10 ` Petr Mladek
2016-12-23 1:46 ` Sergey Senozhatsky
2016-12-23 9:53 ` Petr Mladek
2016-12-21 14:36 ` [PATCHv6 7/7] printk: remove zap_locks() function Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161222011722.GA644@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=calvinowens@fb.com \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peter@hurleysoftware.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).