From: Bjorn Helgaas <helgaas@kernel.org>
To: John Crispin <john@phrozen.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Gabor Juhos <juhosg@openwrt.org>
Subject: Re: [PATCH] pci: add kernel config option for disabling common PCI quirks
Date: Thu, 22 Dec 2016 12:45:53 -0600 [thread overview]
Message-ID: <20161222184553.GA16590@bhelgaas-glaptop.roam.corp.google.com> (raw)
In-Reply-To: <dba6a1d8-d1d6-581e-8a1b-7988ff2577e0@phrozen.org>
On Thu, Dec 22, 2016 at 06:54:51AM +0100, John Crispin wrote:
> On 21/12/2016 15:26, Christoph Hellwig wrote:
> > On Wed, Dec 21, 2016 at 02:11:25PM +0100, John Crispin wrote:
> >> I can turn it into an enable patch that is selected by default.
> >>
> >> The current patch disables all those quirks that are used for x86/PC
> >> style machines and hence are not required in the embedded world.
> >
> > Maybe we'll just need to reorganize the quirks so that most of them
> > arch in arch code or the affected drivers?
>
> to be honest i have no opinion on this. I am currently trying to reduce
> the amount of patches that we have inside the LEDE tree. the patches
> were written by other people and then dumped on us. obviously i am
> interested to get this upstream with the least amount of effort. I am
> quite aware though that some patches will need an overhaul to be
> applicable for upstream. its not really my call if it is enough to make
> this an enable patch and review the quirks enabled by it or if the code
> needs to be moved.
We already have CONFIG_PCI_QUIRKS, which enables everything in
drivers/pci/quirks.c. That file should contain quirks for devices
that may appear on any architecture, e.g., things on plug-in cards.
Quirks that are only applicable to one arch should be in the arch
directory, e.g., in arch/x86/pci/fixup.c.
If drivers/pci/quirks.c contains arch-specific quirks, we should move
those to the appropriate arch directory.
It looks like arch/x86/pci/fixup.c is currently compiled
unconditionally (on x86 with PCI), but we should probably make it
dependent on CONFIG_PCI_QUIRKS, since I think the infrastructure that
*calls* those quirks is only present when CONFIG_PCI_QUIRKS=y.
Bjorn
prev parent reply other threads:[~2016-12-22 18:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 7:53 [PATCH] pci: add kernel config option for disabling common PCI quirks John Crispin
2016-12-21 10:19 ` Lukas Wunner
2016-12-21 12:22 ` Christoph Hellwig
2016-12-21 13:11 ` John Crispin
2016-12-21 14:26 ` Christoph Hellwig
2016-12-22 5:54 ` John Crispin
2016-12-22 18:45 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161222184553.GA16590@bhelgaas-glaptop.roam.corp.google.com \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=hch@infradead.org \
--cc=john@phrozen.org \
--cc=juhosg@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).