From: Stephen Boyd <sboyd@codeaurora.org>
To: Imran Khan <kimran@codeaurora.org>
Cc: andy.gross@linaro.org, lee.jones@linaro.org,
David Brown <david.brown@linaro.org>,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-soc@vger.kernel.org
Subject: Re: [PATCH v6] soc: qcom: Add SoC info driver
Date: Wed, 28 Dec 2016 14:35:09 -0800 [thread overview]
Message-ID: <20161228223509.GA17126@codeaurora.org> (raw)
In-Reply-To: <e4e9a825-fb73-242a-7c66-f8bb4783cfcd@codeaurora.org>
On 12/23, Imran Khan wrote:
> On 12/22/2016 6:01 AM, Stephen Boyd wrote:
> >
> > Raw numbers sounds fine, but how do we know what ODM it is to
> > understand how to parse the numbers appropriately? Perhaps the
> > smem DT entry needs to have a property indicating the ODM that
> > has configured these numbers, and then we can have an ODM sysfs
> > node that we use to expose that string property to userspace?
> >
> Okay smem DT entry can be used to provide ODM information but even after
> having this feature, I am not sure if we can provide a code in the driver
> that will act for all ODMs because we don't know how other ODMs will interpret
> platform types and subtypes numbers.
> Or do you mean here that we should keep string values corresponding to different
> platform type and subtype numbers in the smem DT entry itself. We will use
> socinfo from smem to get the raw number and then translate that raw number to
> a string, using the mapping given in DT itself.
>
I mean in DT
smem {
compatible = "qcom,smem";
qcom,odm = "odm_name";
}
And then in the driver code we look for the qcom,odm property and
make a sysfs attribute called odm or something that exposes the
string "odm_name" to userspace. Then we have some userspace
database of odm string and platform type/subtype numbers that we
can use to figure out what those numbers mean.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2016-12-28 22:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 15:17 [PATCH v6] soc: qcom: Add SoC info driver Imran Khan
2016-12-13 19:17 ` Bjorn Andersson
2016-12-14 0:26 ` Stephen Boyd
2016-12-15 16:29 ` Imran Khan
2016-12-17 1:26 ` Stephen Boyd
2016-12-18 18:12 ` Imran Khan
2016-12-20 22:50 ` Stephen Boyd
2016-12-21 7:10 ` Imran Khan
2016-12-22 0:31 ` Stephen Boyd
2016-12-22 21:23 ` Imran Khan
2016-12-28 22:35 ` Stephen Boyd [this message]
2016-12-29 5:46 ` Imran Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161228223509.GA17126@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=david.brown@linaro.org \
--cc=kimran@codeaurora.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).