From: Richard Cochran <richardcochran@gmail.com>
To: Nicolas Ferre <nicolas.ferre@atmel.com>
Cc: Rafal Ozieblo <rafalo@cadence.com>,
Andrei Pistirica <andrei.pistirica@microchip.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"harinikatakamlinux@gmail.com" <harinikatakamlinux@gmail.com>,
"harini.katakam@xilinx.com" <harini.katakam@xilinx.com>,
"punnaia@xilinx.com" <punnaia@xilinx.com>,
"michals@xilinx.com" <michals@xilinx.com>,
"anirudh@xilinx.com" <anirudh@xilinx.com>,
"boris.brezillon@free-electrons.com"
<boris.brezillon@free-electrons.com>,
"alexandre.belloni@free-electrons.com"
<alexandre.belloni@free-electrons.com>,
"tbultel@pixelsurmer.com" <tbultel@pixelsurmer.com>
Subject: Re: [RFC PATCH net-next v4 1/2] macb: Add 1588 support in Cadence GEM.
Date: Mon, 2 Jan 2017 17:13:59 +0100 [thread overview]
Message-ID: <20170102161359.GD3609@localhost.localdomain> (raw)
In-Reply-To: <0717c63b-2e29-9ad1-7f01-39817980933f@atmel.com>
On Mon, Jan 02, 2017 at 03:47:07PM +0100, Nicolas Ferre wrote:
> Le 02/01/2017 à 12:31, Richard Cochran a écrit :
> > This Cadence IP core is a complete disaster.
>
> Well, it evolved and propose several options to different SoC
> integrators. This is not something unusual...
> I suspect as well that some other network adapters have the same
> weakness concerning PTP timestamp in single register as the early
> revisions of this IP.
It appears that this core can neither latch the time on read or write,
or even latch time stamps. I have worked with many different PTP HW
implementations, even early ones like on the ixp4xx, and it is no
exaggeration to say that this one is uniquely broken.
> I suspect that Rafal tend to jump too quickly to the latest IP revisions
> and add more options to this series: let's not try to pour too much
> things into this code right now.
Why can't you check the IP version in the driver?
And is it really true that the registers don't latch the time stamps,
as Rafal said? If so, then we cannot accept the non-descriptor driver
version, since it cannot possibly work correctly.
Thanks,
Richard
next prev parent reply other threads:[~2017-01-02 16:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 12:56 [RFC PATCH net-next v4 1/2] macb: Add 1588 support in Cadence GEM Andrei Pistirica
2016-12-14 12:56 ` [RFC PATCH net-next v4 2/2] macb: Enable 1588 support in SAMA5Dx platforms Andrei Pistirica
2016-12-20 16:38 ` Rafal Ozieblo
2016-12-28 8:15 ` [RFC PATCH net-next v4 1/2] macb: Add 1588 support in Cadence GEM Richard Cochran
2016-12-28 13:23 ` Rafal Ozieblo
2017-01-02 9:36 ` Rafal Ozieblo
2017-01-02 11:31 ` Richard Cochran
2017-01-02 11:43 ` Harini Katakam
2017-01-02 16:03 ` Richard Cochran
2017-01-02 14:47 ` Nicolas Ferre
2017-01-02 16:13 ` Richard Cochran [this message]
2017-01-03 5:06 ` Harini Katakam
2017-01-03 10:20 ` Richard Cochran
2017-01-03 10:29 ` Richard Cochran
2017-01-03 10:48 ` Harini Katakam
2017-01-03 10:47 ` Rafal Ozieblo
2017-01-03 11:14 ` Richard Cochran
2017-01-11 14:34 ` Andrei.Pistirica
2017-01-03 14:22 ` Nicolas Ferre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170102161359.GD3609@localhost.localdomain \
--to=richardcochran@gmail.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=andrei.pistirica@microchip.com \
--cc=anirudh@xilinx.com \
--cc=boris.brezillon@free-electrons.com \
--cc=davem@davemloft.net \
--cc=harini.katakam@xilinx.com \
--cc=harinikatakamlinux@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michals@xilinx.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@atmel.com \
--cc=punnaia@xilinx.com \
--cc=rafalo@cadence.com \
--cc=tbultel@pixelsurmer.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).