From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH] pinctrl: qcom: msm8660: rename some SDC1->SDC4
Date: Mon, 2 Jan 2017 10:19:55 -0800 [thread overview]
Message-ID: <20170102181955.GB23061@minitux> (raw)
In-Reply-To: <20170102084228.7890-1-linus.walleij@linaro.org>
On Mon 02 Jan 00:42 PST 2017, Linus Walleij wrote:
> These four pins are for SDC4, not SDC1. They are grouped for
> SDC4 later in the file so this must be a typo.
>
> Cc: Björn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Regards,
Bjorn
> ---
> drivers/pinctrl/qcom/pinctrl-msm8660.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/pinctrl/qcom/pinctrl-msm8660.c b/drivers/pinctrl/qcom/pinctrl-msm8660.c
> index 5591d093bf78..bb71dd1e6279 100644
> --- a/drivers/pinctrl/qcom/pinctrl-msm8660.c
> +++ b/drivers/pinctrl/qcom/pinctrl-msm8660.c
> @@ -193,9 +193,9 @@ static const struct pinctrl_pin_desc msm8660_pins[] = {
> PINCTRL_PIN(171, "GPIO_171"),
> PINCTRL_PIN(172, "GPIO_172"),
>
> - PINCTRL_PIN(173, "SDC1_CLK"),
> - PINCTRL_PIN(174, "SDC1_CMD"),
> - PINCTRL_PIN(175, "SDC1_DATA"),
> + PINCTRL_PIN(173, "SDC4_CLK"),
> + PINCTRL_PIN(174, "SDC4_CMD"),
> + PINCTRL_PIN(175, "SDC4_DATA"),
> PINCTRL_PIN(176, "SDC3_CLK"),
> PINCTRL_PIN(177, "SDC3_CMD"),
> PINCTRL_PIN(178, "SDC3_DATA"),
> --
> 2.9.3
>
prev parent reply other threads:[~2017-01-02 18:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 8:42 [PATCH] pinctrl: qcom: msm8660: rename some SDC1->SDC4 Linus Walleij
2017-01-02 18:19 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170102181955.GB23061@minitux \
--to=bjorn.andersson@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).