From: Mike Snitzer <snitzer@redhat.com>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Jens Axboe <axboe@fb.com>,
linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
linux-block@vger.kernel.org, "maintainer:DEVICE-MAPPER LVM,
Shaohua Li <shli@kernel.org>,
linux-raid@vger.kernel.org open list:SOFTWARE RAID Multiple
DisksSUPPORT" <dm-devel@redhat.com>,
Alasdair Kergon <agk@redhat.com>
Subject: Re: [PATCH v1 12/54] dm: limit the max bio size as BIO_MAX_PAGES * PAGE_SIZE
Date: Tue, 3 Jan 2017 11:43:13 -0500 [thread overview]
Message-ID: <20170103164312.GA20421@redhat.com> (raw)
In-Reply-To: <1482854250-13481-13-git-send-email-tom.leiming@gmail.com>
On Tue, Dec 27 2016 at 10:56am -0500,
Ming Lei <tom.leiming@gmail.com> wrote:
> For BIO based DM, some targets aren't ready for dealing with
> bigger incoming bio than 1Mbyte, such as crypt target.
>
> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
> ---
> drivers/md/dm.c | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/md/dm.c b/drivers/md/dm.c
> index 3086da5664f3..6139bf7623f7 100644
> --- a/drivers/md/dm.c
> +++ b/drivers/md/dm.c
> @@ -899,7 +899,16 @@ int dm_set_target_max_io_len(struct dm_target *ti, sector_t len)
> return -EINVAL;
> }
>
> - ti->max_io_len = (uint32_t) len;
> + /*
> + * BIO based queue uses its own splitting. When multipage bvecs
> + * is switched on, size of the incoming bio may be too big to
> + * be handled in some targets, such as crypt.
> + *
> + * When these targets are ready for the big bio, we can remove
> + * the limit.
> + */
> + ti->max_io_len = min_t(uint32_t, len,
> + (BIO_MAX_PAGES * PAGE_SIZE));
>
> return 0;
> }
> --
> 2.7.4
dm_set_target_max_io_len() is already meant to be called by the .ctr
hook for each DM target. So why not just have the dm-crypt target (and
other targets if needed) pass your reduced $len?
That way only targets that need to be fixed (e.g. dm-crypt) impose this
limit.
next prev parent reply other threads:[~2017-01-03 16:43 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1482854250-13481-1-git-send-email-tom.leiming@gmail.com>
2016-12-27 15:55 ` [PATCH v1 01/54] block: drbd: comment on direct access bvec table Ming Lei
2016-12-27 15:55 ` [PATCH v1 02/54] block: loop: comment on direct access to " Ming Lei
2016-12-27 15:55 ` [PATCH v1 03/54] kernel/power/swap.c: " Ming Lei
2016-12-27 15:55 ` [PATCH v1 04/54] mm: page_io.c: " Ming Lei
2016-12-27 15:55 ` [PATCH v1 05/54] fs/buffer: " Ming Lei
2016-12-27 15:55 ` [PATCH v1 06/54] f2fs: f2fs_read_end_io: " Ming Lei
2016-12-27 15:55 ` [PATCH v1 07/54] bcache: " Ming Lei
2016-12-30 16:56 ` Coly Li
2016-12-27 15:55 ` [PATCH v1 08/54] block: comment on bio_alloc_pages() Ming Lei
2016-12-30 10:40 ` Coly Li
2016-12-30 11:06 ` Coly Li
2016-12-27 15:55 ` [PATCH v1 09/54] block: comment on bio_iov_iter_get_pages() Ming Lei
2016-12-27 15:55 ` [PATCH v1 10/54] block: introduce flag QUEUE_FLAG_NO_MP Ming Lei
2016-12-27 15:56 ` [PATCH v1 11/54] md: set NO_MP for request queue of md Ming Lei
2016-12-27 15:56 ` [PATCH v1 12/54] dm: limit the max bio size as BIO_MAX_PAGES * PAGE_SIZE Ming Lei
2017-01-03 16:43 ` Mike Snitzer [this message]
2017-01-06 3:30 ` Ming Lei
2016-12-27 15:56 ` [PATCH v1 13/54] block: comments on bio_for_each_segment[_all] Ming Lei
2016-12-27 15:56 ` [PATCH v1 14/54] block: introduce multipage/single page bvec helpers Ming Lei
2016-12-27 15:56 ` [PATCH v1 15/54] block: implement sp version of bvec iterator helpers Ming Lei
2016-12-27 15:56 ` [PATCH v1 16/54] block: introduce bio_for_each_segment_mp() Ming Lei
2016-12-27 15:56 ` [PATCH v1 17/54] block: introduce bio_clone_sp() Ming Lei
2016-12-27 15:56 ` [PATCH v1 18/54] bvec_iter: introduce BVEC_ITER_ALL_INIT Ming Lei
2016-12-27 15:56 ` [PATCH v1 19/54] block: bounce: avoid direct access to bvec table Ming Lei
2016-12-27 15:56 ` [PATCH v1 20/54] block: bounce: don't access bio->bi_io_vec in copy_to_high_bio_irq Ming Lei
2016-12-27 15:56 ` [PATCH v1 21/54] block: introduce bio_can_convert_to_sp() Ming Lei
2016-12-27 15:56 ` [PATCH v1 22/54] block: bounce: convert multipage bvecs into singlepage Ming Lei
2016-12-27 15:56 ` [PATCH v1 23/54] bcache: handle bio_clone() & bvec updating for multipage bvecs Ming Lei
2016-12-30 11:01 ` Coly Li
2016-12-31 10:29 ` Ming Lei
2016-12-27 15:56 ` [PATCH v1 24/54] blk-merge: compute bio->bi_seg_front_size efficiently Ming Lei
2016-12-27 15:56 ` [PATCH v1 25/54] block: blk-merge: try to make front segments in full size Ming Lei
2016-12-27 15:56 ` [PATCH v1 26/54] block: blk-merge: remove unnecessary check Ming Lei
2016-12-27 15:56 ` [PATCH v1 27/54] block: use bio_for_each_segment_mp() to compute segments count Ming Lei
2016-12-27 15:56 ` [PATCH v1 28/54] block: use bio_for_each_segment_mp() to map sg Ming Lei
2016-12-27 15:56 ` [PATCH v1 29/54] block: introduce bvec_for_each_sp_bvec() Ming Lei
2016-12-27 15:56 ` [PATCH v1 30/54] block: bio: introduce single/multi page version of bio_for_each_segment_all() Ming Lei
2016-12-27 15:56 ` [PATCH v1 31/54] block: introduce bio_segments_all() Ming Lei
2017-01-16 3:19 ` [PATCH v1 00/54] block: support multipage bvec Ming Lei
2017-01-16 15:18 ` Christoph Hellwig
2017-01-17 2:40 ` Ming Lei
2017-01-17 7:50 ` Christoph Hellwig
2017-01-17 8:13 ` Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103164312.GA20421@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=axboe@fb.com \
--cc=dm-devel@redhat.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).