From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jiandi An <anjiandi@codeaurora.org>
Cc: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
tpmdd-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [tpmdd-devel] [PATCH] tpm, tpm_crb: Handle 64-bit resource in crb_check_resource()
Date: Tue, 3 Jan 2017 19:11:49 +0200 [thread overview]
Message-ID: <20170103171149.pwrbhy5uw4cqvwn4@intel.com> (raw)
In-Reply-To: <5858CD6F.5000909@codeaurora.org>
On Tue, Dec 20, 2016 at 12:19:27AM -0600, Jiandi An wrote:
> The control area buffer is specified in the TPM2.0 static ACPI table. TPM
> CRB driver maps the control area address and reads out cmd and rsp buffer
> addresses and maps them. There is no requirement in the TCG TPM ACPI spec
> for specifying _CRS to describe the control area buffer. When I rebased
> the early prototype for CRB driver ARM64 enablement to the latest kernel,
> I hit this issue where I have to specify _CRS method. So in _CRS method
> I specify the same control area address that's in the TPM2.0 static ACPI table.
>
> I see the _CRS requirement in the CRB driver is for resource synchronization
> between the TIS and CRB drivers to support force mode in TIS. Could I get some
> background on that so I could be more careful not breaking TIS while making
> changes to CRB driver for ARM64 enablement?
At least couple of reasons:
- _CRS is required to access locality registers (check my patch set
that is waiting for review/testing).
- On x86 and PTT _CRS always exists and that's the only platform
where this driver has been used so far.
/Jarkko
next prev parent reply other threads:[~2017-01-03 17:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-19 4:20 [PATCH] tpm, tpm_crb: Handle 64-bit resource in crb_check_resource() Jiandi An
2016-12-19 13:56 ` Jarkko Sakkinen
2016-12-19 16:22 ` Jason Gunthorpe
2016-12-20 6:19 ` [tpmdd-devel] " Jiandi An
2017-01-03 17:11 ` Jarkko Sakkinen [this message]
2017-01-03 18:27 ` Jarkko Sakkinen
2017-01-09 18:43 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103171149.pwrbhy5uw4cqvwn4@intel.com \
--to=jarkko.sakkinen@linux.intel.com \
--cc=anjiandi@codeaurora.org \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).