From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "Pali Rohár" <pali.rohar@gmail.com>,
"Michał Kępień" <kernel@kempniu.pl>,
"Jean Delvare" <jdelvare@suse.com>,
"Wolfram Sang" <wsa@the-dreams.de>,
"Steven Honeyman" <stevenhoneyman@gmail.com>,
Valdis.Kletnieks@vt.edu,
"Jochen Eisinger" <jochen@penguin-breeder.org>,
"Gabriele Mazzotta" <gabriele.mzt@gmail.com>,
"Andy Lutomirski" <luto@kernel.org>,
Mario_Limonciello@dell.com, "Alex Hung" <alex.hung@canonical.com>,
"Takashi Iwai" <tiwai@suse.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] i2c: i801: Register optional lis3lv02d i2c device on Dell machines
Date: Wed, 4 Jan 2017 10:13:38 +0100 [thread overview]
Message-ID: <20170104091338.GO5767@mail.corp.redhat.com> (raw)
In-Reply-To: <20170104063642.GA20545@dtor-ws>
On Jan 03 2017 or thereabouts, Dmitry Torokhov wrote:
> On Tue, Jan 03, 2017 at 10:29:34PM +0100, Benjamin Tissoires wrote:
> > On Jan 03 2017 or thereabouts, Dmitry Torokhov wrote:
> >
> > > Yet another option: can we add a new flag to i2c_board_info controlling
> > > whether we want to enable/disable wiring up host notify interrupt?
> >
> > That should be fairly easy to implement. For now, given that only Elan
> > and Synaptics are the one in need for Host Notify, it could be better to
> > request the Host Notify IRQ instead of disabling it unconditionally
> > (which would make the current yet 8 years old lis3lv02d driver happy
> > again).
>
> I like that we have it done in i2c core instead of having drivers
> implementing it individually. Since you are saying that handling host
> notify is property of the slave/driver maybe we should be adding a flag
> to the *i2c_driver* structure to let i2c core that we want to have host
> notify mapped as interrupt if "native" interrupt is not supplied by the
> platform code?
I don't think this is a good idea. It's still a property of the I2C
device, not the driver. It's crappy under Windows, but that doesn't
prevent us to do the right thing.
I think the idea of having it at the i2c_board_info level is the good
one. It's a property of the device node and it wouldn't hurt me to have
a device tree property for that too (not entering the DT field now).
There is no ACPI prop for it too, but I wouldn't be surprised if it
comes in a later revision. The advantage of having it turned on
unconditionally is that we can instantiate it from userspace without
breaking the sysfs ABI.
Note that in the 2 uses I have seen so far of Host Notify, in both cases
I need to instantiate the I2C device from an other driver (psmouse) so I
can control the content of i2c_board_info.
Cheers,
Benjamin
next prev parent reply other threads:[~2017-01-04 9:25 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 12:52 [PATCH] i2c: i801: Register optional lis3lv02d i2c device on Dell machines Pali Rohár
2016-12-27 13:43 ` Wolfram Sang
2016-12-27 13:51 ` Pali Rohár
2016-12-27 22:15 ` Andy Shevchenko
2016-12-27 22:41 ` Valdis.Kletnieks
2016-12-28 7:55 ` Andy Shevchenko
2016-12-28 9:05 ` Pali Rohár
2016-12-28 14:03 ` Wolfram Sang
2016-12-29 4:37 ` Valdis.Kletnieks
2016-12-28 8:38 ` Pali Rohár
2016-12-28 14:02 ` Wolfram Sang
2017-01-04 9:45 ` Jean Delvare
2016-12-29 8:29 ` Michał Kępień
2016-12-29 9:00 ` Pali Rohár
2016-12-29 13:47 ` Michał Kępień
2016-12-29 14:17 ` Pali Rohár
2016-12-29 21:09 ` Michał Kępień
2016-12-29 21:28 ` Pali Rohár
2017-01-03 9:06 ` Benjamin Tissoires
2017-01-03 9:23 ` Pali Rohár
2017-01-03 18:38 ` Dmitry Torokhov
2017-01-03 18:50 ` Pali Rohár
2017-01-03 18:58 ` Mario.Limonciello
2017-01-03 19:48 ` Dmitry Torokhov
2017-01-03 20:05 ` Pali Rohár
2017-01-03 20:24 ` Dmitry Torokhov
2017-01-03 20:39 ` Pali Rohár
2017-01-03 20:59 ` Dmitry Torokhov
2017-01-04 8:18 ` Pali Rohár
2017-01-04 9:05 ` Benjamin Tissoires
2017-01-04 9:18 ` Pali Rohár
2017-01-04 10:13 ` Benjamin Tissoires
2017-01-04 10:21 ` Pali Rohár
2017-01-04 10:32 ` Benjamin Tissoires
2017-01-04 11:22 ` Pali Rohár
2017-01-04 12:00 ` Pali Rohár
2017-01-04 13:02 ` Benjamin Tissoires
2017-01-04 16:06 ` Pali Rohár
2017-01-04 17:39 ` Benjamin Tissoires
2017-01-04 17:46 ` Wolfram Sang
2017-01-04 17:54 ` Dmitry Torokhov
2017-01-04 21:49 ` Benjamin Tissoires
2017-01-04 21:55 ` Dmitry Torokhov
2017-01-04 21:55 ` Wolfram Sang
2017-01-04 22:00 ` Dmitry Torokhov
2017-01-04 22:03 ` Dmitry Torokhov
2017-01-05 2:20 ` [PATCH] i2c: do not enable fall back to Host Notify by default kbuild test robot
2017-01-05 2:21 ` kbuild test robot
2017-01-05 8:54 ` [PATCH] i2c: i801: Register optional lis3lv02d i2c device on Dell machines Pali Rohár
2017-01-05 9:26 ` Benjamin Tissoires
2017-01-04 18:50 ` Jean Delvare
2017-01-04 9:53 ` Andy Shevchenko
2017-01-04 10:25 ` Benjamin Tissoires
2017-01-04 11:35 ` Pali Rohár
2017-01-04 12:33 ` Benjamin Tissoires
2017-01-03 21:29 ` Benjamin Tissoires
2017-01-04 6:36 ` Dmitry Torokhov
2017-01-04 9:13 ` Benjamin Tissoires [this message]
2017-01-04 9:25 ` Pali Rohár
2017-01-03 20:20 ` Andy Shevchenko
2017-01-04 10:18 ` Jean Delvare
2017-01-07 12:49 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104091338.GO5767@mail.corp.redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=Mario_Limonciello@dell.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=alex.hung@canonical.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gabriele.mzt@gmail.com \
--cc=jdelvare@suse.com \
--cc=jochen@penguin-breeder.org \
--cc=kernel@kempniu.pl \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=stevenhoneyman@gmail.com \
--cc=tiwai@suse.de \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).