From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
Ingo Molnar <mingo@redhat.com>,
Josh Poimboeuf <jpoimboe@redhat.com>,
linux-kernel@vger.kernel.org,
Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H . Peter Anvin" <hpa@zytor.com>,
Andrey Konovalov <andreyknvl@google.com>
Subject: Re: [PATCH tip/master v3] kprobes: extable: Identify kprobes' insn-slots as kernel text area
Date: Wed, 4 Jan 2017 09:21:45 -0500 [thread overview]
Message-ID: <20170104092145.23c0e24d@gandalf.local.home> (raw)
In-Reply-To: <20170103105402.GB25813@worktop.programming.kicks-ass.net>
On Tue, 3 Jan 2017 11:54:02 +0100
Peter Zijlstra <peterz@infradead.org> wrote:
> How many entries should one expect on that list? I spend quite a bit of
> time reducing the cost of is_module_text_address() a while back and see
> that both ftrace (which actually needs this to be fast) and now
> kprobes have linear list walks in here.
>
> I'm assuming the ftrace thing to be mostly empty, since I never saw it
> on my benchmarks back then, but it is something Steve should look at I
> suppose.
Yeah, that do_for_each_ftrace_op() loop iterates all the users that
have connected to function tracing. Which in your case is probably at
most 2 (one for ftrace and one for perf). You could get more by
creating instances and enabling function tracing there too. Oh, and the
stack tracer could add its own.
Hmm, with the addition of live kernel patching, this list could get
larger. As you can have one per updated function. But heh, that's just
part of the overhead for live patching ;-)
-- Steve
prev parent reply other threads:[~2017-01-04 14:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 6:42 Detecting kprobes generated code addresses Josh Poimboeuf
2016-12-25 3:13 ` Masami Hiramatsu
2016-12-25 6:16 ` Masami Hiramatsu
2016-12-26 4:30 ` Masami Hiramatsu
2016-12-26 14:50 ` [PATCH tip/master] kprobes: extable: Identify kprobes' insn-slots as kernel text area Masami Hiramatsu
2016-12-26 15:34 ` [PATCH tip/master v2] " Masami Hiramatsu
2016-12-26 17:21 ` kbuild test robot
2016-12-26 17:46 ` kbuild test robot
2016-12-27 6:13 ` Masami Hiramatsu
2016-12-27 6:14 ` [PATCH tip/master v3] " Masami Hiramatsu
2017-01-03 10:54 ` Peter Zijlstra
2017-01-04 5:06 ` Masami Hiramatsu
2017-01-04 10:01 ` Peter Zijlstra
2017-01-08 4:22 ` Masami Hiramatsu
2017-01-08 12:31 ` Masami Hiramatsu
2017-01-08 14:58 ` [PATCH tip/master v4] " Masami Hiramatsu
2017-01-09 17:36 ` Josh Poimboeuf
2017-01-10 1:11 ` Masami Hiramatsu
2017-01-10 8:59 ` Peter Zijlstra
2017-01-10 21:42 ` Josh Poimboeuf
2017-01-11 9:57 ` Masami Hiramatsu
2017-01-14 9:56 ` [tip:perf/core] kprobes, extable: Identify kprobes trampolines " tip-bot for Masami Hiramatsu
2017-01-04 14:21 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104092145.23c0e24d@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=ananth@linux.vnet.ibm.com \
--cc=andreyknvl@google.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).