From: Lee Jones <lee.jones@linaro.org>
To: Marek Vasut <marex@denx.de>
Cc: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>,
linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com,
linux-input@vger.kernel.org, jic23@kernel.org, knaack.h@gmx.de,
lars@metafoo.de, pmeerw@pmeerw.net, linux-iio@vger.kernel.org,
harald@ccbib.org, stefan.wahren@i2se.com,
fabio.estevam@freescale.com
Subject: Re: [PATCH v11 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD
Date: Wed, 4 Jan 2017 10:33:08 +0000 [thread overview]
Message-ID: <20170104103308.GV27589@dell> (raw)
In-Reply-To: <8b5ad884-ed94-c776-043d-1dbdd64182d2@denx.de>
On Thu, 08 Dec 2016, Marek Vasut wrote:
> On 12/08/2016 11:27 PM, Ksenija Stanojevic wrote:
> > Add core files for low resolution analog-to-digital converter (mxs-lradc)
> > MFD driver.
> >
> > Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@gmail.com>
>
> Just a nit below.
>
> > +++ b/include/linux/mfd/mxs-lradc.h
> > @@ -0,0 +1,187 @@
> > +/*
>
> [...]
>
> > +#define LRADC_CTRL1_MX28_LRADC_IRQ_EN_MASK (0x1fff << 16)
> > +#define LRADC_CTRL1_MX23_LRADC_IRQ_EN_MASK (0x01ff << 16)
> > +#define LRADC_CTRL1_LRADC_IRQ_EN_OFFSET 16
> > +#define LRADC_CTRL1_TOUCH_DETECT_IRQ BIT(8)
> > +#define LRADC_CTRL1_LRADC_IRQ(n) (1 << (n))
>
> This would turn into BIT(n) , no ?
Once you have fixed this, you can apply my:
For my own reference:
Acked-for-MFD-by: Lee Jones <lee.jones@linaro.org>
> > +#define LRADC_CTRL1_MX28_LRADC_IRQ_MASK 0x1fff
> > +#define LRADC_CTRL1_MX23_LRADC_IRQ_MASK 0x01ff
> > +#define LRADC_CTRL1_LRADC_IRQ_OFFSET 0
>
> [...]
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-01-04 10:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 22:27 [PATCH v11 0/5] mxs-lradc: Split driver into MFD Ksenija Stanojevic
2016-12-08 22:27 ` [PATCH v11 1/5] mfd: mxs-lradc: Add support for mxs-lradc MFD Ksenija Stanojevic
2016-12-08 22:56 ` Marek Vasut
2017-01-04 10:33 ` Lee Jones [this message]
2016-12-08 22:27 ` [PATCH v11 2/5] iio: adc: mxs-lradc: Add support for adc driver Ksenija Stanojevic
2016-12-08 22:27 ` [PATCH v11 3/5] input: touchscreen: mxs-lradc: Add support for touchscreen Ksenija Stanojevic
2016-12-27 22:39 ` Dmitry Torokhov
2017-01-20 12:25 ` Stefan Wahren
2017-01-21 20:57 ` Ksenija Stanojević
2017-01-23 10:53 ` Ksenija Stanojević
2016-12-08 22:27 ` [PATCH v11 4/5] iio: adc: mxs-lradc: Remove driver Ksenija Stanojevic
2016-12-08 22:27 ` [PATCH v11 5/5] mfd: Move binding document Ksenija Stanojevic
2017-01-04 10:57 ` Lee Jones
2016-12-08 23:02 ` [PATCH v11 0/5] mxs-lradc: Split driver into MFD Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104103308.GV27589@dell \
--to=lee.jones@linaro.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fabio.estevam@freescale.com \
--cc=harald@ccbib.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=ksenija.stanojevic@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marex@denx.de \
--cc=pmeerw@pmeerw.net \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).