From: Sebastian Reichel <sre@kernel.org>
To: Chris Lapa <chris@lapa.com.au>
Cc: pali.rohar@gmail.com, afd@ti.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/11] power: supplies: bq275xx: rename BQ27500 allow for deprecation in future.
Date: Fri, 6 Jan 2017 00:59:57 +0100 [thread overview]
Message-ID: <20170105235957.jfoffcnlqqpw36vp@earth> (raw)
In-Reply-To: <1482451507-37676-2-git-send-email-chris@lapa.com.au>
[-- Attachment #1: Type: text/plain, Size: 1055 bytes --]
Hi Chris,
On Fri, Dec 23, 2016 at 11:04:57AM +1100, Chris Lapa wrote:
> From: Chris Lapa <chris@lapa.com.au>
>
> The BQ275XX definition exists only to satisfy backwards compatibility.
>
> tested: yes
>
> Signed-off-by: Chris Lapa <chris@lapa.com.au>
>
> [...]
>
> static bool bq27xxx_battery_overtemp(struct bq27xxx_device_info *di, u16 flags)
> {
> - if (di->chip == BQ27500 || di->chip == BQ27541 || di->chip == BQ27545)
> + if (di->chip == BQ275XX || di->chip == BQ27541 || di->chip == BQ27545)
> return flags & (BQ27XXX_FLAG_OTC | BQ27XXX_FLAG_OTD);
> if (di->chip == BQ27530 || di->chip == BQ27421)
> return flags & BQ27XXX_FLAG_OT;
This is really getting out of hands in this patchset. Please
add a patch at the beginning of the patchset, which converts
this construct into the following:
switch (di->chip) {
case A:
case B:
case C:
case D:
return flags & (BQ27XXX_FLAG_OTC | BQ27XXX_FLAG_OTD);
case E:
case F:
return flags & BQ27XXX_FLAG_OT;
default:
return false;
}
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-01-06 0:09 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 1:22 [PATCH 00/10] power: supply: bq275xx: implement individual chip revision support Chris Lapa
2016-12-22 1:22 ` [PATCH 01/10] power: supplies: bq275xx: rename BQ27500 allow for deprecation in future Chris Lapa
2016-12-22 1:22 ` [PATCH 02/10] power: supplies: bq275xx: adds specific support for bq27500/1 revision Chris Lapa
2016-12-22 1:22 ` [PATCH 03/10] power: supplies: bq275xx: adds specific support for bq27510-g1 revision Chris Lapa
2016-12-22 1:22 ` [PATCH 04/10] power: supplies: bq275xx: adds specific support for bq27510-g2 revision Chris Lapa
2016-12-22 1:22 ` [PATCH 05/10] power: supplies: bq275xx: adds specific support for bq27510-g3 revision Chris Lapa
2016-12-22 1:22 ` [PATCH 06/10] power: supplies: bq275xx: adds specific support for bq27520-g1 revision Chris Lapa
2016-12-22 1:22 ` [PATCH 07/10] power: supplies: bq275xx: adds specific support for bq27520-g2 revision Chris Lapa
2016-12-22 1:22 ` [PATCH 08/10] power: supplies: bq275xx: adds specific support for bq27520-g3 revision Chris Lapa
2016-12-22 1:22 ` [PATCH 09/10] power: supplies: bq275xx: adds specific support for bq27520-g4 revision Chris Lapa
2016-12-22 8:57 ` Pali Rohár
2016-12-23 0:04 ` [PATCH v2 00/11] power: supply: bq275xx: implement individual chip revision support Chris Lapa
2016-12-23 0:04 ` [PATCH v2 01/11] power: supplies: bq275xx: rename BQ27500 allow for deprecation in future Chris Lapa
2017-01-05 23:59 ` Sebastian Reichel [this message]
2017-01-06 0:29 ` Chris Lapa
2017-01-06 17:36 ` Sebastian Reichel
2016-12-23 0:04 ` [PATCH v2 02/11] power: supplies: bq275xx: adds specific support for bq27500/1 revision Chris Lapa
2016-12-23 0:04 ` [PATCH v2 03/11] power: supplies: bq275xx: adds specific support for bq27510-g1 revision Chris Lapa
2016-12-23 0:05 ` [PATCH v2 04/11] power: supplies: bq275xx: adds specific support for bq27510-g2 revision Chris Lapa
2016-12-23 0:05 ` [PATCH v2 05/11] power: supplies: bq275xx: adds specific support for bq27510-g3 revision Chris Lapa
2016-12-23 0:05 ` [PATCH v2 06/11] power: supplies: bq275xx: adds specific support for bq27520-g1 revision Chris Lapa
2016-12-23 0:05 ` [PATCH v2 07/11] power: supplies: bq275xx: adds specific support for bq27520-g2 revision Chris Lapa
2016-12-23 0:05 ` [PATCH v2 08/11] power: supplies: bq275xx: adds specific support for bq27520-g3 revision Chris Lapa
2016-12-23 0:05 ` [PATCH v2 09/11] power: supplies: bq275xx: adds specific support for bq27520-g4 revision Chris Lapa
2016-12-23 0:05 ` [PATCH v2 10/11] power: supply: bq275xx: cleanup over temperature flag check Chris Lapa
2016-12-23 0:05 ` [PATCH v2 11/11] power: supplies: bq275xx: adds device tree binding documentation Chris Lapa
2017-01-06 0:06 ` Sebastian Reichel
2017-01-06 0:32 ` Chris Lapa
2017-01-09 0:47 ` [PATCH v3 00/11] power: supply: bq275xx: implement individual chip revision support Chris Lapa
2017-01-09 0:47 ` [PATCH v3 01/11] power: supplies: bq275xx: move overtemp tests to a switch statement Chris Lapa
2017-01-09 15:35 ` Andrew F. Davis
2017-01-09 0:47 ` [PATCH v3 02/11] power: supplies: bq275xx: rename BQ27500 allow for deprecation in future Chris Lapa
2017-01-09 0:47 ` [PATCH v3 03/11] power: supplies: bq275xx: adds specific support for bq27500/1 revision Chris Lapa
2017-01-09 0:47 ` [PATCH v3 04/11] power: supplies: bq275xx: adds specific support for bq27510-g1 revision Chris Lapa
2017-01-09 0:47 ` [PATCH v3 05/11] power: supplies: bq275xx: adds specific support for bq27510-g2 revision Chris Lapa
2017-01-09 0:47 ` [PATCH v3 06/11] power: supplies: bq275xx: adds specific support for bq27510-g3 revision Chris Lapa
2017-01-09 0:47 ` [PATCH v3 07/11] power: supplies: bq275xx: adds specific support for bq27520-g1 revision Chris Lapa
2017-01-09 0:47 ` [PATCH v3 08/11] power: supplies: bq275xx: adds specific support for bq27520-g2 revision Chris Lapa
2017-01-09 0:47 ` [PATCH v3 09/11] power: supplies: bq275xx: adds specific support for bq27520-g3 revision Chris Lapa
2017-01-09 0:47 ` [PATCH v3 10/11] power: supplies: bq275xx: adds specific support for bq27520-g4 revision Chris Lapa
2017-01-09 0:47 ` [PATCH v3 11/11] power: supplies: bq27xxx: adds device tree binding documentation Chris Lapa
2017-01-09 8:23 ` [PATCH v3 00/11] power: supply: bq275xx: implement individual chip revision support Pali Rohár
2017-01-10 2:49 ` Sebastian Reichel
2017-01-10 5:25 ` [PATCH v4 00/10] power: supply: bq27xxx: " Chris Lapa
2017-01-10 5:25 ` [PATCH v4 01/10] power: supplies: bq27xxx: rename BQ27500 allow for deprecation in future Chris Lapa
2017-01-10 8:58 ` Pali Rohár
2017-01-10 22:25 ` Chris Lapa
2017-01-10 23:29 ` Sebastian Reichel
2017-01-10 5:25 ` [PATCH v4 02/10] power: supplies: bq27xxx: adds specific support for bq27500/1 revision Chris Lapa
2017-01-10 5:25 ` [PATCH v4 03/10] power: supplies: bq27xxx: adds specific support for bq27510-g1 revision Chris Lapa
2017-01-10 5:25 ` [PATCH v4 04/10] power: supplies: bq27xxx: adds specific support for bq27510-g2 revision Chris Lapa
2017-01-10 5:25 ` [PATCH v4 05/10] power: supplies: bq27xxx: adds specific support for bq27510-g3 revision Chris Lapa
2017-01-10 5:25 ` [PATCH v4 06/10] power: supplies: bq27xxx: adds specific support for bq27520-g1 revision Chris Lapa
2017-01-10 5:25 ` [PATCH v4 07/10] power: supplies: bq27xxx: adds specific support for bq27520-g2 revision Chris Lapa
2017-01-10 5:25 ` [PATCH v4 08/10] power: supplies: bq27xxx: adds specific support for bq27520-g3 revision Chris Lapa
2017-01-10 5:25 ` [PATCH v4 09/10] power: supplies: bq27xxx: adds specific support for bq27520-g4 revision Chris Lapa
2017-01-10 5:25 ` [PATCH v4 10/10] power: supplies: bq27xxx: adds device tree binding documentation Chris Lapa
2017-01-11 1:44 ` [PATCH v5 00/11] power: supply: bq27xxx: implement individual chip revision support Chris Lapa
2017-01-11 1:44 ` [PATCH v5 01/11] power: supply: bq27xxx: rename BQ27500 allow for deprecation in future Chris Lapa
2017-01-11 1:44 ` [PATCH v5 02/11] power: supply: bq27xxx: rename BQ27510 " Chris Lapa
2017-01-11 1:44 ` [PATCH v5 03/11] power: supply: bq27xxx: adds specific support for bq27500/1 revision Chris Lapa
2017-01-11 1:44 ` [PATCH v5 04/11] power: supply: bq27xxx: adds specific support for bq27510-g1 revision Chris Lapa
2017-01-11 1:44 ` [PATCH v5 05/11] power: supply: bq27xxx: adds specific support for bq27510-g2 revision Chris Lapa
2017-01-11 1:44 ` [PATCH v5 06/11] power: supply: bq27xxx: adds specific support for bq27510-g3 revision Chris Lapa
2017-01-11 1:44 ` [PATCH v5 07/11] power: supply: bq27xxx: adds specific support for bq27520-g1 revision Chris Lapa
2017-01-11 1:44 ` [PATCH v5 08/11] power: supply: bq27xxx: adds specific support for bq27520-g2 revision Chris Lapa
2017-01-11 1:44 ` [PATCH v5 09/11] power: supply: bq27xxx: adds specific support for bq27520-g3 revision Chris Lapa
2017-01-11 1:44 ` [PATCH v5 10/11] power: supply: bq27xxx: adds specific support for bq27520-g4 revision Chris Lapa
2017-01-11 1:44 ` [PATCH v5 11/11] power: supply: bq27xxx: adds device tree binding documentation Chris Lapa
2017-01-12 2:54 ` [PATCH v5 00/11] power: supply: bq27xxx: implement individual chip revision support Sebastian Reichel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170105235957.jfoffcnlqqpw36vp@earth \
--to=sre@kernel.org \
--cc=afd@ti.com \
--cc=chris@lapa.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pali.rohar@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).