linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Andrew Duggan <aduggan@synaptics.com>,
	Christopher Heiny <cheiny@synaptics.com>,
	Nick Dyer <nick@shmanahar.org>,
	linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] Input: synaptics-rmi4 - make F03 a tristate symbol
Date: Tue, 10 Jan 2017 13:16:58 +0100	[thread overview]
Message-ID: <20170110121718.2992211-1-arnd@arndb.de> (raw)

If CONFIG_INPUT=m, we get a build error for the rmi4-f03 driver,
added in linux-4.10:

drivers/input/built-in.o: In function `rmi_f03_attention':
rmi_f03.c:(.text+0xcfe0): undefined reference to `serio_interrupt'
rmi_f03.c:(.text+0xd055): undefined reference to `serio_interrupt'
drivers/input/built-in.o: In function `rmi_f03_remove':
rmi_f03.c:(.text+0xd115): undefined reference to `serio_unregister_port'
drivers/input/built-in.o: In function `rmi_f03_probe':
rmi_f03.c:(.text+0xd209): undefined reference to `__serio_register_port'

If we make the driver itself a 'tristate' instead of 'bool' symbol,
Kconfig ensures that it can only be a loadable module in this case,
which avoids the problem.

Fixes: c5e8848fc98e ("Input: synaptics-rmi4 - add support for F03")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/input/rmi4/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/input/rmi4/Kconfig b/drivers/input/rmi4/Kconfig
index 30cc627a4f45..ad945b25722c 100644
--- a/drivers/input/rmi4/Kconfig
+++ b/drivers/input/rmi4/Kconfig
@@ -40,7 +40,7 @@ config RMI4_SMB
 	  called rmi_smbus.
 
 config RMI4_F03
-        bool "RMI4 Function 03 (PS2 Guest)"
+        tristate "RMI4 Function 03 (PS2 Guest)"
         depends on RMI4_CORE && SERIO
         help
           Say Y here if you want to add support for RMI4 function 03.
-- 
2.9.0

             reply	other threads:[~2017-01-10 12:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-10 12:16 Arnd Bergmann [this message]
2017-01-11  0:39 ` [PATCH] Input: synaptics-rmi4 - make F03 a tristate symbol Andrew Duggan
2017-01-11 15:39   ` Arnd Bergmann
2017-01-11 16:28     ` Benjamin Tissoires
2017-01-11 16:54       ` Arnd Bergmann
2017-01-11 17:48         ` Benjamin Tissoires
2017-01-11 19:27           ` Christopher Heiny
2017-01-13  0:42             ` Andrew Duggan
2017-01-13 21:14               ` Arnd Bergmann
2017-01-13  6:22 ` Dmitry Torokhov
2017-01-13 21:06   ` Arnd Bergmann
2017-01-13 21:15     ` Dmitry Torokhov
2017-01-13 21:34       ` Arnd Bergmann
2017-01-13 21:42         ` Dmitry Torokhov
2017-01-14 12:09           ` Arnd Bergmann
2017-01-15 23:39             ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170110121718.2992211-1-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=aduggan@synaptics.com \
    --cc=cheiny@synaptics.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nick@shmanahar.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).