From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755780AbdARL1R (ORCPT ); Wed, 18 Jan 2017 06:27:17 -0500 Received: from mx1.redhat.com ([209.132.183.28]:50932 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753185AbdARL1O (ORCPT ); Wed, 18 Jan 2017 06:27:14 -0500 Date: Wed, 18 Jan 2017 12:16:54 +0100 From: Jiri Olsa To: Andi Kleen Cc: Andi Kleen , acme@kernel.org, jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] perf, tools: Add probing for xed Message-ID: <20170118111654.GA8813@krava> References: <20170110010225.24870-1-andi@firstfloor.org> <20170110010225.24870-2-andi@firstfloor.org> <20170111183714.GB29004@krava> <20170111221756.GG8388@tassilo.jf.intel.com> <20170112085253.GA31701@krava> <20170112173937.GA5460@tassilo.jf.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170112173937.GA5460@tassilo.jf.intel.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Wed, 18 Jan 2017 11:16:57 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2017 at 09:39:37AM -0800, Andi Kleen wrote: > On Thu, Jan 12, 2017 at 09:52:53AM +0100, Jiri Olsa wrote: > > On Wed, Jan 11, 2017 at 02:17:56PM -0800, Andi Kleen wrote: > > > > > diff --git a/tools/build/Makefile.feature b/tools/build/Makefile.feature > > > > > index e3fb5ecbdcb6..971a9ef87ca6 100644 > > > > > --- a/tools/build/Makefile.feature > > > > > +++ b/tools/build/Makefile.feature > > > > > @@ -63,7 +63,7 @@ FEATURE_TESTS_BASIC := \ > > > > > lzma \ > > > > > get_cpuid \ > > > > > bpf \ > > > > > - sdt > > > > > + sdt \ > > > > > > > > looks like you forgot to add xed in here? why the '\' ? > > > > > > I removed it, but incompletely. > > > > > > > anyway, please add it in here so it's visible under make VF=1 > > > > > > If I add it here then it is shown by default (even without VF=1). > > > Arnaldo requested earlier that it shouldn't be shown. > > > > if you put it to FEATURE_TESTS_BASIC then it's displayed only for VF=1 > > It's already in FEATURE_TESTS_BASIC: > > @ -63,7 +63,8 @@ FEATURE_TESTS_BASIC := \ > lzma \ > get_cpuid \ > bpf \ > - sdt > + sdt \ > + xed I see that on FEATURE_TESTS_EXTRA in your xed-4 branch, unless that's different to what you sent out jirka