From: Lee Jones <lee.jones@linaro.org>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: gregkh@linuxfoundation.org, jslaby@suse.com,
linux-serial@vger.kernel.org, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@stlinux.com
Subject: Re: [STLinux Kernel] [PATCH 8/8] ARM: dts: STiH407-family: Enable HW flow-control
Date: Fri, 27 Jan 2017 11:33:52 +0000 [thread overview]
Message-ID: <20170127113352.paie6vzo23ax7nxt@dell> (raw)
In-Reply-To: <20170125114002.GG5680@griffinp-ThinkPad-X1-Carbon-2nd>
On Wed, 25 Jan 2017, Peter Griffin wrote:
> On Wed, 25 Jan 2017, Peter Griffin wrote:
> > On Tue, 24 Jan 2017, Lee Jones wrote:
> >
> > > Hardware flow-control capability must be specified at a platform
> > > level in order to inform the ASC driver that the platform is capable
> > > (i.e. are the lines wired up, etc). STiH4{07,10} devices are indeed
> > > capable, so let's provide the property.
> > >
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > ---
> > > arch/arm/boot/dts/stih407-family.dtsi | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/boot/dts/stih407-family.dtsi b/arch/arm/boot/dts/stih407-family.dtsi
> > > index 9789978..7ada8ea 100644
> > > --- a/arch/arm/boot/dts/stih407-family.dtsi
> > > +++ b/arch/arm/boot/dts/stih407-family.dtsi
> > > @@ -226,7 +226,7 @@
> > > pinctrl-0 = <&pinctrl_serial0_flowctrl>;
> > > pinctrl-1 = <&pinctrl_serial0>;
> > > clocks = <&clk_s_c0_flexgen CLK_EXT2F_A9>;
> > > -
> > > + st,hw-flow-control;
> >
> > There is a generic serial binding for this already. As this ST property
> > hasn't been used upstream, it seems like it would be worth dropping it
> > and switching to the generic uart-has-rtscts one.
> >
> > See Documentation/devicetree/bindings/serial/serial.txt
> >
> > - uart-has-rtscts: The presence of this property indicates that the
> > UART has dedicated lines for RTS/CTS hardware flow control, and that
> > they are available for use (wired and enabled by pinmux configuration).
> > This depends on both the UART hardware and the board wiring.
> > Note that this property is mutually-exclusive with "cts-gpios" and
> > "rts-gpios" above.
>
> Thinking some more this generic binding definition is a bit restrictive,
> particularly the "Note that this property is mutually-exclusive with "cts-gpios"
> and "rts-gpios"" part.
>
> As with this series we will have dynamic on-the-fly changing from hw flow
> control to gpio control for other configs which the HW IP doesn't support.
>
> IMO the uart-has-rtscts definition should be updated to reflect that they can
> be used together in certain circumstances.
Ah, you noticed that too. Yes, will update the doc.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-01-27 11:34 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-24 13:43 [PATCH 0/8] serial: st-asc: Allow handling of RTS line Lee Jones
2017-01-24 13:43 ` [PATCH 1/8] serial: st-asc: Ignore the parity error bit if 8-bit mode is enabled Lee Jones
2017-01-25 11:02 ` [STLinux Kernel] " Peter Griffin
2017-01-24 13:43 ` [PATCH 2/8] serial: st-asc: Provide RTS functionality Lee Jones
2017-01-25 11:03 ` [STLinux Kernel] " Peter Griffin
2017-01-24 13:43 ` [PATCH 3/8] serial: st-asc: Read in all Pinctrl states Lee Jones
2017-01-24 21:28 ` kbuild test robot
2017-01-25 11:21 ` [STLinux Kernel] " Peter Griffin
2017-01-27 11:54 ` Lee Jones
2017-01-30 14:23 ` Peter Griffin
2017-01-30 15:32 ` Lee Jones
2017-01-30 16:10 ` Peter Griffin
2017-01-30 19:11 ` Lee Jones
2017-01-30 22:35 ` Peter Griffin
2017-01-31 10:13 ` Lee Jones
2017-01-31 11:31 ` Peter Griffin
2017-01-31 12:27 ` Lee Jones
2017-02-01 11:50 ` Peter Griffin
2017-02-01 12:47 ` Lee Jones
2017-01-24 13:43 ` [PATCH 4/8] serial: st-asc: (De)Register GPIOD and swap Pinctrl profiles Lee Jones
2017-01-24 22:00 ` kbuild test robot
2017-01-25 11:24 ` [STLinux Kernel] " Peter Griffin
2017-01-24 13:43 ` [PATCH 5/8] ARM: dts: STiH410-b2260: Identify the UART RTS line Lee Jones
2017-01-24 13:43 ` [PATCH 6/8] ARM: dts: STiH407-pinctrl: Add Pinctrl group for HW flow-control Lee Jones
2017-01-25 11:01 ` [STLinux Kernel] " Peter Griffin
2017-01-24 13:43 ` [PATCH 7/8] ARM: dts: STiH407-family: Use new Pinctrl groups Lee Jones
2017-01-25 11:54 ` [STLinux Kernel] " Peter Griffin
2017-01-27 11:03 ` Lee Jones
2017-01-27 11:29 ` Lee Jones
2017-01-24 13:43 ` [PATCH 8/8] ARM: dts: STiH407-family: Enable HW flow-control Lee Jones
2017-01-25 10:59 ` [STLinux Kernel] " Peter Griffin
2017-01-25 11:40 ` Peter Griffin
2017-01-27 11:33 ` Lee Jones [this message]
2017-01-27 11:32 ` Lee Jones
2017-01-25 10:07 ` [PATCH 0/8] serial: st-asc: Allow handling of RTS line Greg KH
2017-01-25 15:35 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170127113352.paie6vzo23ax7nxt@dell \
--to=lee.jones@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kernel@stlinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).