From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751318AbdBOAeJ (ORCPT ); Tue, 14 Feb 2017 19:34:09 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:60208 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750816AbdBOAeI (ORCPT ); Tue, 14 Feb 2017 19:34:08 -0500 Date: Tue, 14 Feb 2017 16:34:06 -0800 From: Andrew Morton To: Kees Cook Cc: Djalal Harouni , LKML , "kernel-hardening@lists.openwall.com" , Lafcadio Wluiki Subject: Re: [PATCH v4 1/2] procfs: use an enum for possible hidepid values Message-Id: <20170214163406.1ed8e7d707510d14137f1dd6@linux-foundation.org> In-Reply-To: References: <1484572984-13388-1-git-send-email-djalal@gmail.com> <1484572984-13388-2-git-send-email-djalal@gmail.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 13 Feb 2017 14:16:30 -0800 Kees Cook wrote: > On Mon, Jan 16, 2017 at 5:23 AM, Djalal Harouni wrote: > > From: Lafcadio Wluiki > > > > Previously, the hidepid parameter was checked by comparing literal > > integers 0, 1, 2. Let's add a proper enum for this, to make the checking > > more expressive: > > > > 0 ___ HIDEPID_OFF > > 1 ___ HIDEPID_NO_ACCESS > > 2 ___ HIDEPID_INVISIBLE > > > > This changes the internal labelling only, the userspace-facing interface > > remains unmodified, and still works with literal integers 0, 1, 2. > > > > No functional changes. > > > > Acked-by: Kees Cook > > Acked-by: Djalal Harouni > > Signed-off-by: Lafcadio Wluiki > > Andrew, can you take this? It's a sensible cleanup to drop literals in > favor of defines. Sure. Djalal, I converted your acked-by into a signed-off-by, as described in Documentation/SubmittingPatches (soon to become Documentation/process/submitting-patches.rst).