From: Lee Jones <lee.jones@linaro.org>
To: Joe Perches <joe@perches.com>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Tony Lindgren <tony@atomide.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH 23/35] drivers/mfd: Convert remaining uses of pr_warning to pr_warn
Date: Tue, 14 Mar 2017 14:04:55 +0000 [thread overview]
Message-ID: <20170314140455.umlhdbuj3grqtu6i@dell> (raw)
In-Reply-To: <a6c827c14d0b9f4be42e549ec4c629245516e979.1487314667.git.joe@perches.com>
On Thu, 16 Feb 2017, Joe Perches wrote:
> To enable eventual removal of pr_warning
>
> This makes pr_warn use consistent for drivers/mfd
>
> Prior to this patch, there were 4 uses of pr_warning and
> 9 uses of pr_warn in drivers/mfd
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> drivers/mfd/db8500-prcmu.c | 2 +-
> drivers/mfd/sta2x11-mfd.c | 4 ++--
> drivers/mfd/twl4030-power.c | 7 ++-----
> 3 files changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
> index ca38a6a14110..5c739ac752e8 100644
> --- a/drivers/mfd/db8500-prcmu.c
> +++ b/drivers/mfd/db8500-prcmu.c
> @@ -2377,7 +2377,7 @@ static void ack_dbb_wakeup(void)
>
> static inline void print_unknown_header_warning(u8 n, u8 header)
> {
> - pr_warning("prcmu: Unknown message header (%d) in mailbox %d.\n",
> + pr_warn("prcmu: Unknown message header (%d) in mailbox %d\n",
> header, n);
> }
>
> diff --git a/drivers/mfd/sta2x11-mfd.c b/drivers/mfd/sta2x11-mfd.c
> index 9292202039ee..3aeafa228baf 100644
> --- a/drivers/mfd/sta2x11-mfd.c
> +++ b/drivers/mfd/sta2x11-mfd.c
> @@ -60,8 +60,8 @@ static struct sta2x11_mfd *sta2x11_mfd_find(struct pci_dev *pdev)
> struct sta2x11_mfd *mfd;
>
> if (!pdev && !list_empty(&sta2x11_mfd_list)) {
> - pr_warning("%s: Unspecified device, "
> - "using first instance\n", __func__);
> + pr_warn("%s: Unspecified device, using first instance\n",
> + __func__);
> return list_entry(sta2x11_mfd_list.next,
> struct sta2x11_mfd, list);
> }
> diff --git a/drivers/mfd/twl4030-power.c b/drivers/mfd/twl4030-power.c
> index 1beb722f6080..8be023ba8e3e 100644
> --- a/drivers/mfd/twl4030-power.c
> +++ b/drivers/mfd/twl4030-power.c
> @@ -502,9 +502,7 @@ static int load_twl4030_script(const struct twl4030_power_data *pdata,
> }
> if (tscript->flags & TWL4030_SLEEP_SCRIPT) {
> if (!order)
> - pr_warning("TWL4030: Bad order of scripts (sleep "\
> - "script before wakeup) Leads to boot"\
> - "failure on some boards\n");
> + pr_warn("TWL4030: Bad order of scripts (sleep script before wakeup) Leads to boot failure on some boards\n");
Is 80 chars considered the lessor sin?
> err = twl4030_config_sleep_sequence(address);
> }
> out:
> @@ -929,8 +927,7 @@ static int twl4030_power_probe(struct platform_device *pdev)
> err = twl_i2c_read_u8(TWL_MODULE_PM_MASTER, &val,
> TWL4030_PM_MASTER_CFG_P123_TRANSITION);
> if (err) {
> - pr_warning("TWL4030 Unable to read registers\n");
> -
> + pr_warn("TWL4030 Unable to read registers\n");
> } else if (!(val & SEQ_OFFSYNC)) {
> val |= SEQ_OFFSYNC;
> err = twl_i2c_write_u8(TWL_MODULE_PM_MASTER, val,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-03-14 14:06 UTC|newest]
Thread overview: 75+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-17 7:11 [PATCH 00/35] treewide trivial patches converting pr_warning to pr_warn Joe Perches
2017-02-17 7:11 ` [PATCH 01/35] alpha: Convert remaining uses of " Joe Perches
2017-02-17 7:11 ` [PATCH 02/35] ARM: ep93xx: " Joe Perches
2017-02-17 16:26 ` Hartley Sweeten
2017-02-17 7:11 ` [PATCH 03/35] arm64: " Joe Perches
2017-02-17 10:52 ` Mark Rutland
2017-02-17 7:11 ` [PATCH 04/35] arch/blackfin: " Joe Perches
2017-02-17 7:11 ` [PATCH 05/35] ia64: Convert remaining use " Joe Perches
2017-02-17 7:11 ` [PATCH 06/35] powerpc: Convert remaining uses " Joe Perches
2017-02-20 4:40 ` Michael Ellerman
2017-02-20 4:43 ` Joe Perches
2017-02-20 17:25 ` Geoff Levand
2017-02-17 7:11 ` [PATCH 07/35] sh: " Joe Perches
2017-02-17 7:11 ` [PATCH 08/35] sparc: Convert remaining use " Joe Perches
2017-02-17 8:39 ` Sam Ravnborg
2017-02-17 15:20 ` David Miller
2017-02-17 7:11 ` [PATCH 09/35] x86: Convert remaining uses " Joe Perches
2017-02-17 7:46 ` Pekka Paalanen
2017-02-17 8:06 ` Juergen Gross
2017-02-17 11:17 ` Thomas Gleixner
2017-02-17 14:07 ` Robert Richter
2017-02-17 15:01 ` Steven Rostedt
2017-02-21 1:12 ` Adan Hawthorn
2017-02-17 7:11 ` [PATCH 10/35] drivers/acpi: " Joe Perches
2017-02-17 7:11 ` [PATCH 11/35] block/drbd: " Joe Perches
2017-02-17 7:11 ` [PATCH 12/35] gdrom: " Joe Perches
2017-02-17 7:11 ` [PATCH 13/35] drivers/char: Convert remaining use " Joe Perches
2017-02-17 7:53 ` Amit Shah
2017-02-17 7:11 ` [PATCH 14/35] clocksource: " Joe Perches
2017-02-17 7:11 ` [PATCH 15/35] drivers/crypto: Convert remaining uses " Joe Perches
2017-02-17 7:11 ` [PATCH 16/35] fmc: Convert remaining use " Joe Perches
2017-02-17 7:11 ` [PATCH 17/35] drivers/gpu: Convert remaining uses " Joe Perches
2017-02-17 14:22 ` Christian König
2017-02-18 5:03 ` Edward O'Callaghan
2017-02-23 15:02 ` Alex Deucher
2017-02-17 7:11 ` [PATCH 18/35] drivers/ide: " Joe Perches
2017-02-17 15:20 ` David Miller
2017-02-17 7:11 ` [PATCH 19/35] drivers/input: " Joe Perches
2017-02-17 7:11 ` [PATCH 20/35] drivers/isdn: " Joe Perches
2017-02-17 8:49 ` Paul Bolle
2017-02-17 7:11 ` [PATCH 21/35] drivers/macintosh: " Joe Perches
2017-02-17 7:11 ` [PATCH 22/35] drivers/media: Convert remaining use " Joe Perches
2017-02-17 7:11 ` [PATCH 23/35] drivers/mfd: Convert remaining uses " Joe Perches
2017-03-14 14:04 ` Lee Jones [this message]
2017-03-14 17:17 ` Joe Perches
2017-03-15 12:23 ` Lee Jones
2017-03-15 14:17 ` Joe Perches
2017-03-23 10:52 ` Lee Jones
2017-02-17 7:11 ` [PATCH 24/35] drivers/mtd: " Joe Perches
2017-04-19 20:11 ` Brian Norris
2017-02-17 7:11 ` [PATCH 25/35] drivers/of: " Joe Perches
2017-02-17 7:11 ` [PATCH 26/35] drivers/oprofile: " Joe Perches
2017-02-17 14:07 ` Robert Richter
2017-02-17 7:11 ` [PATCH 27/35] drivers/platform: " Joe Perches
2017-02-17 7:45 ` Andy Shevchenko
2017-02-17 7:11 ` [PATCH 28/35] drivers/rapidio: Convert remaining use " Joe Perches
2017-02-17 7:11 ` [PATCH 29/35] drivers/scsi: " Joe Perches
2017-02-17 7:11 ` [PATCH 30/35] drivers/sh: " Joe Perches
2017-02-17 7:11 ` [PATCH 31/35] drivers/tty: Convert remaining uses " Joe Perches
2017-02-17 7:11 ` [PATCH 32/35] drivers/video: " Joe Perches
2017-03-21 15:17 ` Bartlomiej Zolnierkiewicz
2017-02-17 7:11 ` [PATCH 33/35] kernel/trace: " Joe Perches
2017-02-17 14:59 ` Steven Rostedt
2017-02-17 7:11 ` [PATCH 34/35] lib: " Joe Perches
2017-02-17 7:11 ` [PATCH 35/35] sound/soc: " Joe Perches
2017-02-17 20:28 ` Nicolin Chen
2017-02-17 23:48 ` Mark Brown
2017-02-17 23:57 ` Nicolin Chen
2017-02-18 0:20 ` Joe Perches
2017-02-20 19:06 ` Mark Brown
2017-02-17 12:27 ` [PATCH 00/35] treewide trivial patches converting " Rafael J. Wysocki
2017-02-23 15:28 ` Rob Herring
2017-02-23 17:18 ` Joe Perches
2017-02-23 17:41 ` Emil Velikov
2017-02-23 17:53 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314140455.umlhdbuj3grqtu6i@dell \
--to=lee.jones@linaro.org \
--cc=joe@perches.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).