From: Herbert Xu <herbert@gondor.apana.org.au>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: elena.reshetova@intel.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, peterz@infradead.org,
gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk,
catalin.marinas@arm.com, mingo@redhat.com, arnd@arndb.de,
luto@kernel.org, "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH 0/5] mm subsystem refcounter conversions
Date: Sun, 19 Mar 2017 00:37:02 +0800 [thread overview]
Message-ID: <20170318163702.GA23796@gondor.apana.org.au> (raw)
In-Reply-To: <20170228172156.de13fdc41a3ca6a4deea7750@linux-foundation.org>
Andrew Morton <akpm@linux-foundation.org> wrote:
>
> The performance implications of this proposal are terrifying.
>
> I suggest adding a set of non-debug inlined refcount functions which
> just fall back to the simple atomic.h operations.
>
> And add a new CONFIG_DEBUG_REFCOUNT. So the performance (and code
> size!) with CONFIG_DEBUG_REFCOUNT=n is unaltered from present code.
> And make CONFIG_DEBUG_REFCOUNT suitably difficult to set.
I agree. Refcounts are used in many performance-critical sites
within the network subsystem.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2017-03-18 17:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-21 9:58 [PATCH 0/5] mm subsystem refcounter conversions Elena Reshetova
2017-02-21 9:58 ` [PATCH 1/5] mm: convert bdi_writeback_congested.refcnt from atomic_t to refcount_t Elena Reshetova
2017-02-21 9:58 ` [PATCH 2/5] mm: convert anon_vma.refcount " Elena Reshetova
2017-02-21 9:58 ` [PATCH 3/5] mm: convert kmemleak_object.use_count " Elena Reshetova
2017-02-21 9:58 ` [PATCH 4/5] mm: convert mm_struct.mm_users " Elena Reshetova
2017-02-21 9:58 ` [PATCH 5/5] mm: convert mm_struct.mm_count " Elena Reshetova
2017-03-01 1:21 ` [PATCH 0/5] mm subsystem refcounter conversions Andrew Morton
2017-03-18 16:37 ` Herbert Xu [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-02-20 10:49 Elena Reshetova
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170318163702.GA23796@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=elena.reshetova@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).