From: Arnaldo Carvalho de Melo <acme@redhat.com>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>,
alexis.berlemont@gmail.com, linux-kernel@vger.kernel.org,
peterz@infradead.org, mingo@redhat.com,
alexander.shishkin@linux.intel.com, mpe@ellerman.id.au,
naveen.n.rao@linux.vnet.ibm.com, maddy@linux.vnet.ibm.com
Subject: Re: [PATCH 2/5] perf/sdt/x86: Add renaming logic for rNN and other registers
Date: Tue, 21 Mar 2017 11:08:07 -0300 [thread overview]
Message-ID: <20170321140807.GB2531@redhat.com> (raw)
In-Reply-To: <20170207121159.b276b0a7383400a9d2452eee@kernel.org>
Em Tue, Feb 07, 2017 at 12:11:59PM +0900, Masami Hiramatsu escreveu:
> On Thu, 2 Feb 2017 16:41:40 +0530
> Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> wrote:
>
> > 'perf probe' is failing for sdt markers whose arguments has rNN
> > (with postfix b/w/d), %rsp, %esp, %sil etc. registers. Add renaming
> > logic for these registers.
> >
>
> Looks good to me.
>
> Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks, applied right after that v5 series from Alexis.
> Thanks!
>
> > Signed-off-by: Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
> > ---
> > tools/perf/arch/x86/util/perf_regs.c | 44 ++++++++++++++++++++++++++----------
> > 1 file changed, 32 insertions(+), 12 deletions(-)
> >
> > diff --git a/tools/perf/arch/x86/util/perf_regs.c b/tools/perf/arch/x86/util/perf_regs.c
> > index 09a7f55..d8a8dcf 100644
> > --- a/tools/perf/arch/x86/util/perf_regs.c
> > +++ b/tools/perf/arch/x86/util/perf_regs.c
> > @@ -48,10 +48,42 @@ static const struct sdt_name_reg sdt_reg_renamings[] = {
> > SDT_NAME_REG(rdx, dx),
> > SDT_NAME_REG(esi, si),
> > SDT_NAME_REG(rsi, si),
> > + SDT_NAME_REG(sil, si),
> > SDT_NAME_REG(edi, di),
> > SDT_NAME_REG(rdi, di),
> > + SDT_NAME_REG(dil, di),
> > SDT_NAME_REG(ebp, bp),
> > SDT_NAME_REG(rbp, bp),
> > + SDT_NAME_REG(bpl, bp),
> > + SDT_NAME_REG(rsp, sp),
> > + SDT_NAME_REG(esp, sp),
> > + SDT_NAME_REG(spl, sp),
> > +
> > + /* rNN registers */
> > + SDT_NAME_REG(r8b, r8),
> > + SDT_NAME_REG(r8w, r8),
> > + SDT_NAME_REG(r8d, r8),
> > + SDT_NAME_REG(r9b, r9),
> > + SDT_NAME_REG(r9w, r9),
> > + SDT_NAME_REG(r9d, r9),
> > + SDT_NAME_REG(r10b, r10),
> > + SDT_NAME_REG(r10w, r10),
> > + SDT_NAME_REG(r10d, r10),
> > + SDT_NAME_REG(r11b, r11),
> > + SDT_NAME_REG(r11w, r11),
> > + SDT_NAME_REG(r11d, r11),
> > + SDT_NAME_REG(r12b, r12),
> > + SDT_NAME_REG(r12w, r12),
> > + SDT_NAME_REG(r12d, r12),
> > + SDT_NAME_REG(r13b, r13),
> > + SDT_NAME_REG(r13w, r13),
> > + SDT_NAME_REG(r13d, r13),
> > + SDT_NAME_REG(r14b, r14),
> > + SDT_NAME_REG(r14w, r14),
> > + SDT_NAME_REG(r14d, r14),
> > + SDT_NAME_REG(r15b, r15),
> > + SDT_NAME_REG(r15w, r15),
> > + SDT_NAME_REG(r15d, r15),
> > SDT_NAME_REG_END,
> > };
> >
> > @@ -88,18 +120,6 @@ int sdt_rename_register(char **pdesc, char *old_name)
> >
> > /* Copy the chars after the register name (if need be) */
> > offset = prefix_len + sdt_len;
> > - if (offset < old_desc_len) {
> > - /*
> > - * The orginal register name can be suffixed by 'b',
> > - * 'w' or 'd' to indicate its size; so, we need to
> > - * skip this char if we met one.
> > - */
> > - char sfx = old_desc[offset];
> > -
> > - if (sfx == 'b' || sfx == 'w' || sfx == 'd')
> > - offset++;
> > - }
> > -
> > if (offset < old_desc_len)
> > memcpy(new_desc + prefix_len + uprobe_len,
> > old_desc + offset, old_desc_len - offset);
> > --
> > 2.9.3
> >
>
>
> --
> Masami Hiramatsu <mhiramat@kernel.org>
next prev parent reply other threads:[~2017-03-21 14:16 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-16 23:55 [PATCH 0/2] perf: add support of SDT probes arguments Alexis Berlemont
2016-11-16 23:56 ` [PATCH 1/2] perf sdt: add scanning of sdt probles arguments Alexis Berlemont
2016-11-16 23:56 ` [PATCH 2/2] perf probe: add sdt probes arguments into the uprobe cmd string Alexis Berlemont
2016-11-17 9:04 ` Hemant Kumar
2016-11-18 23:56 ` [PATCH v2 0/2] " Alexis Berlemont
2016-11-18 23:56 ` [PATCH v2 1/2] perf sdt: add scanning of sdt probles arguments Alexis Berlemont
2016-11-25 14:40 ` Arnaldo Carvalho de Melo
2016-11-26 0:58 ` [PATCH v4 0/2] perf probe: add sdt probes arguments into the uprobe cmd string Alexis Berlemont
2016-12-05 23:42 ` Alexis Berlemont
2016-12-06 14:45 ` Arnaldo Carvalho de Melo
2016-11-26 0:58 ` [PATCH v4 1/2] perf sdt: add scanning of sdt probles arguments Alexis Berlemont
2016-12-07 2:44 ` Masami Hiramatsu
2016-11-26 0:58 ` [PATCH v4 2/2] perf probe: add sdt probes arguments into the uprobe cmd string Alexis Berlemont
2016-12-07 3:26 ` Masami Hiramatsu
2016-12-09 15:14 ` Arnaldo Carvalho de Melo
2016-12-10 10:00 ` Masami Hiramatsu
2016-12-14 0:07 ` [PATCH v5 0/2] " Alexis Berlemont
2016-12-14 7:36 ` Ingo Molnar
2017-01-23 11:23 ` Ravi Bangoria
2017-02-22 22:41 ` Alexis Berlemont
2017-01-24 6:58 ` Ravi Bangoria
2017-01-24 8:22 ` Ingo Molnar
2017-01-24 8:36 ` Ravi Bangoria
2017-02-02 11:11 ` [PATCH 0/5] perf/sdt: Argument support for x86 and powepc Ravi Bangoria
2017-02-02 11:11 ` [PATCH 1/5] perf/sdt: Show proper hint Ravi Bangoria
2017-02-02 13:40 ` Ingo Molnar
2017-02-02 16:20 ` Arnaldo Carvalho de Melo
2017-02-03 10:26 ` [PATCH v2] " Ravi Bangoria
2017-02-03 15:18 ` Arnaldo Carvalho de Melo
2017-02-07 7:53 ` Ingo Molnar
2017-02-07 15:50 ` Arnaldo Carvalho de Melo
2017-02-07 8:00 ` Ingo Molnar
2017-02-16 10:16 ` [RFC] perf/sdt: Directly record SDT event with 'perf record' Ravi Bangoria
2017-02-20 7:08 ` Ingo Molnar
2017-02-20 8:21 ` Ravi Bangoria
2017-02-20 8:42 ` Ingo Molnar
2017-02-20 11:01 ` Ravi Bangoria
2017-02-20 14:11 ` Arnaldo Carvalho de Melo
2017-02-23 8:13 ` Ravi Bangoria
2017-02-23 12:48 ` Arnaldo Carvalho de Melo
2017-02-07 1:13 ` [PATCH v2] perf/sdt: Show proper hint Masami Hiramatsu
2017-02-10 7:44 ` [tip:perf/core] perf sdt: Show proper hint when event not yet in place via 'perf probe' tip-bot for Ravi Bangoria
2017-02-02 11:11 ` [PATCH 2/5] perf/sdt/x86: Add renaming logic for rNN and other registers Ravi Bangoria
2017-02-07 3:11 ` Masami Hiramatsu
2017-03-21 14:08 ` Arnaldo Carvalho de Melo [this message]
2017-03-24 18:45 ` [tip:perf/core] perf sdt x86: " tip-bot for Ravi Bangoria
2017-02-02 11:11 ` [PATCH 3/5] perf/sdt/x86: Move OP parser to tools/perf/arch/x86/ Ravi Bangoria
2017-02-07 3:11 ` Masami Hiramatsu
2017-02-07 5:22 ` Ravi Bangoria
2017-03-21 14:10 ` Arnaldo Carvalho de Melo
2017-03-21 23:00 ` Masami Hiramatsu
2017-03-22 11:22 ` Arnaldo Carvalho de Melo
2017-03-21 14:55 ` Masami Hiramatsu
2017-02-02 11:11 ` [PATCH 4/5] perf/sdt/powerpc: Add argument support Ravi Bangoria
2017-02-02 11:11 ` [PATCH 5/5] perf/probe: Change MAX_CMDLEN Ravi Bangoria
2017-02-07 1:40 ` Masami Hiramatsu
2017-02-07 5:45 ` [PATCH v2] " Ravi Bangoria
2017-03-21 5:19 ` Masami Hiramatsu
2017-03-21 13:37 ` Arnaldo Carvalho de Melo
2017-03-24 18:43 ` [tip:perf/core] perf probe: " tip-bot for Ravi Bangoria
2017-02-07 2:55 ` [PATCH 0/5] perf/sdt: Argument support for x86 and powepc Masami Hiramatsu
2017-03-06 7:53 ` Ravi Bangoria
2017-03-06 13:42 ` Masami Hiramatsu
2017-03-21 5:08 ` [PATCH v5 0/2] perf probe: add sdt probes arguments into the uprobe cmd string Masami Hiramatsu
2016-12-14 0:07 ` [PATCH v5 1/2] perf sdt: add scanning of sdt probles arguments Alexis Berlemont
2017-03-06 13:39 ` Masami Hiramatsu
2017-03-21 13:52 ` Arnaldo Carvalho de Melo
2017-03-24 18:44 ` [tip:perf/core] perf sdt: Add scanning of sdt probes arguments tip-bot for Alexis Berlemont
2016-12-14 0:07 ` [PATCH v5 2/2] perf probe: add sdt probes arguments into the uprobe cmd string Alexis Berlemont
2017-01-24 8:50 ` Ravi Bangoria
2017-03-06 17:23 ` Masami Hiramatsu
2017-03-24 18:44 ` [tip:perf/core] perf probe: Add " tip-bot for Alexis Berlemont
2016-11-18 23:56 ` [PATCH v2 2/2] perf probe: add " Alexis Berlemont
2016-11-21 10:25 ` Hemant Kumar
2016-11-24 23:13 ` [PATCH v3 0/2] " Alexis Berlemont
2016-11-24 23:13 ` [PATCH v3 1/2] perf sdt: add scanning of sdt probles arguments Alexis Berlemont
2016-11-24 23:13 ` [PATCH v3 2/2] perf probe: add sdt probes arguments into the uprobe cmd string Alexis Berlemont
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170321140807.GB2531@redhat.com \
--to=acme@redhat.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexis.berlemont@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mhiramat@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).