From: Lee Jones <lee.jones@linaro.org>
To: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH v4 2/3] mfd: arizona: Display register addresses in hex
Date: Thu, 23 Mar 2017 10:53:43 +0000 [thread overview]
Message-ID: <20170323105343.wrzqbsnzh4wtfwea@dell> (raw)
In-Reply-To: <1489589918-27088-2-git-send-email-ckeepax@opensource.wolfsonmicro.com>
On Wed, 15 Mar 2017, Charles Keepax wrote:
> Register addresses are normally displayed in hex throughout the Arizona
> driver. Update the arizona_poll_reg function to follow this convention.
>
> Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
> ---
>
> No changes since v4.
>
> drivers/mfd/arizona-core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied, thanks.
> diff --git a/drivers/mfd/arizona-core.c b/drivers/mfd/arizona-core.c
> index e00f577..4cb34c3 100644
> --- a/drivers/mfd/arizona-core.c
> +++ b/drivers/mfd/arizona-core.c
> @@ -245,7 +245,7 @@ static int arizona_poll_reg(struct arizona *arizona,
> for (i = 0; i < timeout; i++) {
> ret = regmap_read(arizona->regmap, reg, &val);
> if (ret != 0) {
> - dev_err(arizona->dev, "Failed to read reg %u: %d\n",
> + dev_err(arizona->dev, "Failed to read reg 0x%x: %d\n",
> reg, ret);
> continue;
> }
> @@ -256,7 +256,7 @@ static int arizona_poll_reg(struct arizona *arizona,
> usleep_range(1000, 5000);
> }
>
> - dev_err(arizona->dev, "Polling reg %u timed out: %x\n", reg, val);
> + dev_err(arizona->dev, "Polling reg 0x%x timed out: %x\n", reg, val);
> return -ETIMEDOUT;
> }
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-03-23 10:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-15 14:58 [PATCH v4 1/3] mfd: arizona: Remove duplicate set of ret variable Charles Keepax
2017-03-15 14:58 ` [PATCH v4 2/3] mfd: arizona: Display register addresses in hex Charles Keepax
2017-03-23 10:53 ` Lee Jones [this message]
2017-03-15 14:58 ` [PATCH v4 3/3] mfd: arizona: Refactor arizona_poll_reg Charles Keepax
2017-03-23 10:54 ` Lee Jones
[not found] ` <CGME20170505103102eucas1p20e8a4a84d4bafd39939166aa21def227@eucas1p2.samsung.com>
2017-05-05 10:31 ` Andrzej Hajda
2017-05-05 16:45 ` Charles Keepax
2017-03-23 10:53 ` [PATCH v4 1/3] mfd: arizona: Remove duplicate set of ret variable Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170323105343.wrzqbsnzh4wtfwea@dell \
--to=lee.jones@linaro.org \
--cc=ckeepax@opensource.wolfsonmicro.com \
--cc=linux-kernel@vger.kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).