From: Adam Borowski <kilobyte@angband.pl>
To: Chris Mason <clm@fb.com>, Josef Bacik <jbacik@fb.com>,
David Sterba <dsterba@suse.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-btrfs@vger.kernel.org,
Icenowy Zheng <icenowy@aosc.io>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH] btrfs: scrub: use do_div() for 64-by-32 division
Date: Sun, 9 Apr 2017 05:58:54 +0200 [thread overview]
Message-ID: <20170409035854.7swkcndswifd622w@angband.pl> (raw)
In-Reply-To: <20170408210737.5456-1-kilobyte@angband.pl>
On Sat, Apr 08, 2017 at 11:07:37PM +0200, Adam Borowski wrote:
> Unbreaks ARM and possibly other 32-bit architectures.
Turns out those "other 32-bit architectures" happen to include i386.
A modular build:
ERROR: "__udivdi3" [fs/btrfs/btrfs.ko] undefined!
With the patch, i386 builds fine.
> Tested on amd64 where all is fine, and on arm (Odroid-U2) where scrub
> sometimes works, but, like most operations, randomly dies with some badness
> that doesn't look related: io_schedule, kunmap_high. That badness wasn't
> there in 4.11-rc5, needs investigating, but since it's not connected to our
> issue at hand, I consider this patch sort-of tested.
Looks like current -next is pretty broken: while amd64 is ok, on an i386 box
(non-NX Pentium 4) it hangs very early during boot, way before filesystem
modules would be loaded. Qemu boots but has random hangs.
So it looks like it's compile only for now...
--
⢀⣴⠾⠻⢶⣦⠀ Meow!
⣾⠁⢠⠒⠀⣿⡁
⢿⡄⠘⠷⠚⠋⠀ Collisions shmolisions, let's see them find a collision or second
⠈⠳⣄⠀⠀⠀⠀ preimage for double rot13!
next prev parent reply other threads:[~2017-04-09 3:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-08 16:02 Linux next-20170407 failed to build on ARM due to usage of mod in btrfs code Icenowy Zheng
2017-04-08 17:45 ` Fabio Estevam
2017-04-08 18:38 ` Adam Borowski
2017-04-08 21:07 ` [PATCH] btrfs: scrub: use do_div() for 64-by-32 division Adam Borowski
2017-04-09 3:58 ` Adam Borowski [this message]
2017-04-10 1:13 ` Adam Borowski
2017-04-10 11:13 ` David Sterba
2017-04-10 12:50 ` Austin S. Hemmelgarn
2017-04-10 18:41 ` Liu Bo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170409035854.7swkcndswifd622w@angband.pl \
--to=kilobyte@angband.pl \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=festevam@gmail.com \
--cc=icenowy@aosc.io \
--cc=jbacik@fb.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).