From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754155AbdDMQBp (ORCPT ); Thu, 13 Apr 2017 12:01:45 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:59984 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751324AbdDMQBm (ORCPT ); Thu, 13 Apr 2017 12:01:42 -0400 Date: Thu, 13 Apr 2017 09:01:35 -0700 From: "Paul E. McKenney" To: Peter Zijlstra Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, jiangshanlai@gmail.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@efficios.com, josh@joshtriplett.org, tglx@linutronix.de, rostedt@goodmis.org, dhowells@redhat.com, edumazet@google.com, fweisbec@gmail.com, oleg@redhat.com, bobby.prani@gmail.com Subject: Re: [PATCH tip/core/rcu 02/13] lockdep: Use "WARNING" tag on lockdep splats Reply-To: paulmck@linux.vnet.ibm.com References: <20170412165441.GA17149@linux.vnet.ibm.com> <1492016149-18834-2-git-send-email-paulmck@linux.vnet.ibm.com> <20170413091418.ok342icfii6dkvjc@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170413091418.ok342icfii6dkvjc@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-GCONF: 00 x-cbid: 17041316-0052-0000-0000-000001D5EB65 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006929; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000208; SDB=6.00847051; UDB=6.00417876; IPR=6.00625484; BA=6.00005288; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015033; XFM=3.00000013; UTC=2017-04-13 16:01:39 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17041316-0053-0000-0000-00004FEC39FA Message-Id: <20170413160135.GY3956@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-13_11:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1702020001 definitions=main-1704130136 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 13, 2017 at 11:14:18AM +0200, Peter Zijlstra wrote: > On Wed, Apr 12, 2017 at 09:55:38AM -0700, Paul E. McKenney wrote: > > This commit changes lockdep splats to begin lines with "WARNING" and > > to use pr_warn() instead of printk(). This change eases scripted > > analysis of kernel console output. > > > > Reported-by: Dmitry Vyukov > > Reported-by: Ingo Molnar > > Signed-off-by: Paul E. McKenney > > Acked-by: Dmitry Vyukov > > --- > > kernel/locking/lockdep.c | 86 +++++++++++++++++++++--------------------- > > kernel/locking/rtmutex-debug.c | 9 +++-- > > 2 files changed, 48 insertions(+), 47 deletions(-) > > > > diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c > > index a95e5d1f4a9c..e9d4f85b290c 100644 > > --- a/kernel/locking/lockdep.c > > +++ b/kernel/locking/lockdep.c > > @@ -1144,10 +1144,10 @@ print_circular_bug_header(struct lock_list *entry, unsigned int depth, > > return 0; > > > > printk("\n"); > > - printk("======================================================\n"); > > - printk("[ INFO: possible circular locking dependency detected ]\n"); > > + pr_warn("======================================================\n"); > > + pr_warn("WARNING: possible circular locking dependency detected\n"); > > print_kernel_ident(); > > - printk("-------------------------------------------------------\n"); > > + pr_warn("------------------------------------------------------\n"); > > printk("%s/%d is trying to acquire lock:\n", > > curr->comm, task_pid_nr(curr)); > > print_lock(check_src); > > Blergh, not a fan of this patch. Now we have an odd mix of pr_crap() and > printk(). Would you be OK with all of the lockdep messages being updated to WARNING rather than just the RCU-related ones? Thanx, Paul