From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
alsa-devel@alsa-project.org, linux-input@vger.kernel.org,
kvm@vger.kernel.org, devel@linuxdriverproject.org,
linux-efi@vger.kernel.org, linux-acpi@vger.kernel.org
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>
Subject: [PATCH v1 3/8] HID: intel_ish-hid: Use recently introduced uuid_le_cmp_p{p}()
Date: Fri, 21 Apr 2017 17:46:40 +0300 [thread overview]
Message-ID: <20170421144645.45189-3-andriy.shevchenko@linux.intel.com> (raw)
In-Reply-To: <20170421144645.45189-1-andriy.shevchenko@linux.intel.com>
Recently introduced helpers take pointers to uuid_{be|le} instead of
reference.
Using them makes code less ugly.
Cc: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/hid/intel-ish-hid/ishtp/bus.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/hid/intel-ish-hid/ishtp/bus.c b/drivers/hid/intel-ish-hid/ishtp/bus.c
index 5f382fedc2ab..165e21b7ee9f 100644
--- a/drivers/hid/intel-ish-hid/ishtp/bus.c
+++ b/drivers/hid/intel-ish-hid/ishtp/bus.c
@@ -138,8 +138,7 @@ int ishtp_fw_cl_by_uuid(struct ishtp_device *dev, const uuid_le *uuid)
int i, res = -ENOENT;
for (i = 0; i < dev->fw_clients_num; ++i) {
- if (uuid_le_cmp(*uuid, dev->fw_clients[i].props.protocol_name)
- == 0) {
+ if (!uuid_le_cmp_p(uuid, dev->fw_clients[i].props.protocol_name)) {
res = i;
break;
}
--
2.11.0
next prev parent reply other threads:[~2017-04-21 19:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-21 14:46 [PATCH v1 1/8] lib/uuid: Introduce uuid_{be|le}_cmp_p{p}() helpers Andy Shevchenko
2017-04-21 14:46 ` [PATCH v1 2/8] ASoC: Intel: Skylake: Use recently introduced uuid_le_cmp_p{p}() Andy Shevchenko
2017-04-24 4:51 ` Vinod Koul
2017-04-24 8:50 ` Andy Shevchenko
2017-04-21 14:46 ` Andy Shevchenko [this message]
2017-04-21 14:46 ` [PATCH v1 4/8] vfio-mdev: " Andy Shevchenko
2017-04-21 14:46 ` [PATCH v1 5/8] vmbus: Use recently introduced uuid_le_cmp_p{p}() helpers Andy Shevchenko
2017-04-21 14:46 ` [PATCH v1 6/8] mei: " Andy Shevchenko
2017-04-21 14:46 ` [PATCH v1 7/8] efi: " Andy Shevchenko
2017-04-21 14:46 ` [PATCH v1 8/8] ACPI: " Andy Shevchenko
2017-04-21 21:22 ` Rafael J. Wysocki
2017-04-27 12:46 ` Borislav Petkov
2017-04-27 13:09 ` Andy Shevchenko
2017-04-27 15:00 ` Borislav Petkov
2017-04-23 10:29 ` [PATCH v1 1/8] lib/uuid: Introduce uuid_{be|le}_cmp_p{p}() helpers Winkler, Tomas
2017-04-23 12:42 ` Andy Shevchenko
2017-04-23 20:20 ` Winkler, Tomas
2017-04-24 8:53 ` Andy Shevchenko
2017-04-24 10:44 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170421144645.45189-3-andriy.shevchenko@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=benjamin.tissoires@redhat.com \
--cc=devel@linuxdriverproject.org \
--cc=kvm@vger.kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).