On Thu, Apr 27, 2017 at 02:04:15PM +0200, Arnd Bergmann wrote: > On Thu, Apr 27, 2017 at 1:55 PM, Leon Romanovsky wrote: > > On Thu, Apr 27, 2017 at 01:04:02PM +0200, Arnd Bergmann wrote: > >> The previous patch addressed a sparse warning but replaced it with a > >> compiler warning when CONFIG_MODULES is disabled: > >> > >> drivers/net/ethernet/mellanox/mlx5/core/ipoib.c:485:13: error: 'mlx5_rdma_netdev_free' defined but not used [-Werror=unused-function] > >> drivers/net/ethernet/mellanox/mlx5/core/ipoib.c:423:27: error: 'mlx5_rdma_netdev_alloc' defined but not used [-Werror=unused-function] > >> > >> We should never export 'static' functions, so this makes them global > >> again but hides them in another #ifdef like the change before. > >> > >> Fixes: a7082ef066f0 ("mlx5: hide unused functions") > >> Signed-off-by: Arnd Bergmann > > > > Hi Arnd, > > > > Thanks for the patch, but Stephen and Saeed already sent patch similar to it. > > http://marc.info/?l=linux-netdev&m=149288674816288&w=2 > > That link is for the patch that introduced the warning that I'm fixing here, > it showed up yesterday in linux-next. > > Did you misread my patch, or just give the wrong link? Sorry, I misread you patch, because I prepared patch which add users for these functions and didn't notice both "static" and EXPORT_SYMBOLS at the same time. I will send it in a couple of minutes. Thanks > > Arnd > -- > To unsubscribe from this list: send the line "unsubscribe linux-rdma" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html