From: Toshi Kani <toshi.kani@hpe.com>
To: dan.j.williams@intel.com
Cc: dave.jiang@intel.com, vishal.l.verma@intel.com,
linux-nvdimm@ml01.01.org, linux-kernel@vger.kernel.org,
Toshi Kani <toshi.kani@hpe.com>
Subject: [PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear_poison()
Date: Thu, 27 Apr 2017 16:57:06 -0600 [thread overview]
Message-ID: <20170427225706.26791-2-toshi.kani@hpe.com> (raw)
In-Reply-To: <20170427225706.26791-1-toshi.kani@hpe.com>
Badblocks are tracked at both region and device levels.
pmem_clear_poison() and nsio_rw_bytes() call nvdimm_clear_poison()
and then badblocks_clear() to clear badblocks at the device level.
However, it does not update badblocks at the region level, which
makes them inconsistent.
Change nvdimm_clear_poison() to update backblocks at the region
level to keep them consistent.
Signed-off-by: Toshi Kani <toshi.kani@hpe.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Dave Jiang <dave.jiang@intel.com>
Cc: Vishal Verma <vishal.l.verma@intel.com>
---
Based on 'libnvdimm-for-next'.
---
drivers/nvdimm/bus.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/nvdimm/bus.c b/drivers/nvdimm/bus.c
index 43ddfd4..998332d 100644
--- a/drivers/nvdimm/bus.c
+++ b/drivers/nvdimm/bus.c
@@ -179,6 +179,7 @@ long nvdimm_clear_poison(struct device *dev, phys_addr_t phys,
struct nvdimm_bus_descriptor *nd_desc;
struct nd_cmd_clear_error clear_err;
struct nd_cmd_ars_cap ars_cap;
+ struct resource res;
u32 clear_err_unit, mask;
int cmd_rc, rc;
@@ -222,6 +223,14 @@ long nvdimm_clear_poison(struct device *dev, phys_addr_t phys,
if (clear_err.cleared > 0)
nvdimm_forget_poison(nvdimm_bus, phys, clear_err.cleared);
+ if (clear_err.cleared > 0 && clear_err.cleared / 512) {
+ nvdimm_bus_lock(&nvdimm_bus->dev);
+ res.start = phys;
+ res.end = phys + clear_err.cleared - 1;
+ __nvdimm_bus_badblocks_clear(nvdimm_bus, &res);
+ nvdimm_bus_unlock(&nvdimm_bus->dev);
+ }
+
return clear_err.cleared;
}
EXPORT_SYMBOL_GPL(nvdimm_clear_poison);
next prev parent reply other threads:[~2017-04-27 22:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-27 22:57 [PATCH 1/2] libnvdimm: fix clear length of nvdimm_forget_poison() Toshi Kani
2017-04-27 22:57 ` Toshi Kani [this message]
2017-04-29 0:10 ` [PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear_poison() Dan Williams
2017-04-29 0:12 ` Dan Williams
2017-04-29 0:35 ` Dan Williams
2017-05-01 15:05 ` Kani, Toshimitsu
2017-04-28 21:48 ` [PATCH 1/2] libnvdimm: fix clear length of nvdimm_forget_poison() Dan Williams
2017-04-28 22:29 ` Kani, Toshimitsu
2017-04-28 22:39 ` Dan Williams
2017-04-28 22:41 ` Kani, Toshimitsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170427225706.26791-2-toshi.kani@hpe.com \
--to=toshi.kani@hpe.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@ml01.01.org \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).