From: David Miller <davem@davemloft.net>
To: vivien.didelot@savoirfairelinux.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@savoirfairelinux.com, f.fainelli@gmail.com,
andrew@lunn.ch
Subject: Re: [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU
Date: Mon, 01 May 2017 12:26:18 -0400 (EDT) [thread overview]
Message-ID: <20170501.122618.1787371573631638101.davem@davemloft.net> (raw)
In-Reply-To: <87shko7dkk.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me>
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Mon, 01 May 2017 12:21:31 -0400
> Hi David,
>
> David Miller <davem@davemloft.net> writes:
>
>> From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
>> Date: Mon, 01 May 2017 11:51:05 -0400
>>
>>> Hi David,
>>>
>>> Vivien Didelot <vivien.didelot@savoirfairelinux.com> writes:
>>>
>>>> Vivien Didelot (18):
>>>> net: dsa: mv88e6xxx: add max VID to info
>>>> net: dsa: mv88e6xxx: split VTU entry data member
>>>> net: dsa: mv88e6xxx: move VTU Operation accessors
>>>> net: dsa: mv88e6xxx: move VTU flush
>>>> net: dsa: mv88e6xxx: move VTU FID accessors
>>>> net: dsa: mv88e6xxx: move VTU SID accessors
>>>> net: dsa: mv88e6xxx: move VTU VID accessors
>>>> net: dsa: mv88e6xxx: move generic VTU GetNext
>>>> net: dsa: mv88e6xxx: move VTU Data accessors
>>>> net: dsa: mv88e6xxx: move STU GetNext operation
>>>> net: dsa: mv88e6xxx: get STU entry on VTU GetNext
>>>> net: dsa: mv88e6xxx: load STU entry with VTU entry
>>>> net: dsa: mv88e6xxx: add VTU GetNext operation
>>>> net: dsa: mv88e6xxx: add VTU Load/Purge operation
>>>> net: dsa: mv88e6xxx: make VTU helpers static
>>>> net: dsa: mv88e6xxx: simplify VTU entry getter
>>>> net: dsa: mv88e6xxx: support the VTU Page bit
>>>> net: dsa: mv88e6xxx: add VTU support for 88E6390
>>>>
>>>> drivers/net/dsa/mv88e6xxx/Makefile | 1 +
>>>> drivers/net/dsa/mv88e6xxx/chip.c | 568 +++++++++-----------------------
>>>> drivers/net/dsa/mv88e6xxx/global1.h | 14 +
>>>> drivers/net/dsa/mv88e6xxx/global1_vtu.c | 505 ++++++++++++++++++++++++++++
>>>> drivers/net/dsa/mv88e6xxx/mv88e6xxx.h | 31 +-
>>>> 5 files changed, 684 insertions(+), 435 deletions(-)
>>>> create mode 100644 drivers/net/dsa/mv88e6xxx/global1_vtu.c
>>>
>>> I don't see the patchset in net-next. Can you pick it?
>>
>> This had feedback which you must address, therefore the state in
>> patchwork is "changes requested" which you could have checked before
>> asking me this.
>>
>> If the patch set is fine and you got ACKs for all of your patches
>> then please resubmit.
>>
>> Otherwise, make the changes you were asked to make or explain to
>> the person who asked for them why they are not appropriate.
>
> We did discuss the patchset and everything is good as is. Can someone
> change the state in patchwork afterwards? It feels weird to resend the
> patch with no changes.
Once I set the state to "changes requested", that's basically permanent.
Please simply resubmit your patch series, ACKs added if necessary.
Thanks.
next prev parent reply other threads:[~2017-05-01 16:26 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-26 15:53 [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU Vivien Didelot
2017-04-26 15:53 ` [PATCH net-next 01/18] net: dsa: mv88e6xxx: add max VID to info Vivien Didelot
2017-04-26 16:04 ` Andrew Lunn
2017-04-26 15:53 ` [PATCH net-next 02/18] net: dsa: mv88e6xxx: split VTU entry data member Vivien Didelot
2017-04-27 18:25 ` Andrew Lunn
2017-04-26 15:53 ` [PATCH net-next 03/18] net: dsa: mv88e6xxx: move VTU Operation accessors Vivien Didelot
2017-04-27 18:32 ` Andrew Lunn
2017-04-27 18:33 ` Andrew Lunn
2017-04-26 15:53 ` [PATCH net-next 04/18] net: dsa: mv88e6xxx: move VTU flush Vivien Didelot
2017-04-27 18:34 ` Andrew Lunn
2017-04-26 15:53 ` [PATCH net-next 05/18] net: dsa: mv88e6xxx: move VTU FID accessors Vivien Didelot
2017-04-27 18:35 ` Andrew Lunn
2017-04-26 15:53 ` [PATCH net-next 06/18] net: dsa: mv88e6xxx: move VTU SID accessors Vivien Didelot
2017-04-27 18:37 ` Andrew Lunn
2017-04-26 15:53 ` [PATCH net-next 07/18] net: dsa: mv88e6xxx: move VTU VID accessors Vivien Didelot
2017-04-27 18:51 ` Andrew Lunn
2017-04-26 15:53 ` [PATCH net-next 08/18] net: dsa: mv88e6xxx: move generic VTU GetNext Vivien Didelot
2017-04-27 18:59 ` Andrew Lunn
2017-04-28 15:07 ` Vivien Didelot
2017-04-26 15:53 ` [PATCH net-next 09/18] net: dsa: mv88e6xxx: move VTU Data accessors Vivien Didelot
2017-04-27 19:19 ` Andrew Lunn
2017-04-26 15:53 ` [PATCH net-next 10/18] net: dsa: mv88e6xxx: move STU GetNext operation Vivien Didelot
2017-04-27 19:43 ` Andrew Lunn
2017-04-26 15:53 ` [PATCH net-next 11/18] net: dsa: mv88e6xxx: get STU entry on VTU GetNext Vivien Didelot
2017-04-27 20:17 ` Andrew Lunn
2017-04-26 15:53 ` [PATCH net-next 12/18] net: dsa: mv88e6xxx: load STU entry with VTU entry Vivien Didelot
2017-04-28 2:07 ` Andrew Lunn
2017-04-26 15:53 ` [PATCH net-next 13/18] net: dsa: mv88e6xxx: add VTU GetNext operation Vivien Didelot
2017-04-28 2:10 ` Andrew Lunn
2017-04-26 15:53 ` [PATCH net-next 14/18] net: dsa: mv88e6xxx: add VTU Load/Purge operation Vivien Didelot
2017-04-28 2:14 ` Andrew Lunn
2017-04-26 15:53 ` [PATCH net-next 15/18] net: dsa: mv88e6xxx: make VTU helpers static Vivien Didelot
2017-04-28 2:15 ` Andrew Lunn
2017-04-26 15:53 ` [PATCH net-next 16/18] net: dsa: mv88e6xxx: simplify VTU entry getter Vivien Didelot
2017-04-28 2:19 ` Andrew Lunn
2017-04-26 15:53 ` [PATCH net-next 17/18] net: dsa: mv88e6xxx: support the VTU Page bit Vivien Didelot
2017-04-28 12:53 ` Andrew Lunn
2017-04-28 14:25 ` Vivien Didelot
2017-04-28 14:52 ` Andrew Lunn
2017-04-26 15:53 ` [PATCH net-next 18/18] net: dsa: mv88e6xxx: add VTU support for 88E6390 Vivien Didelot
2017-04-28 12:55 ` Andrew Lunn
2017-05-01 15:51 ` [PATCH net-next 00/18] net: dsa: mv88e6xxx: 802.1s and 88E6390 VTU Vivien Didelot
2017-05-01 16:08 ` David Miller
2017-05-01 16:21 ` Vivien Didelot
2017-05-01 16:25 ` Andrew Lunn
2017-05-01 17:16 ` Vivien Didelot
2017-05-01 16:26 ` David Miller [this message]
2017-05-01 16:36 ` Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170501.122618.1787371573631638101.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=f.fainelli@gmail.com \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).