From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Russell King <linux@armlinux.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
alexandre.torgue@st.com, devicetree <devicetree@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet driver
Date: Mon, 1 May 2017 17:58:56 +0200 [thread overview]
Message-ID: <20170501155856.GA1957@Red> (raw)
In-Reply-To: <20170501144541.GB1285@lunn.ch>
On Mon, May 01, 2017 at 04:45:41PM +0200, Andrew Lunn wrote:
> On Mon, May 01, 2017 at 10:28:46PM +0800, Chen-Yu Tsai wrote:
> > On Mon, May 1, 2017 at 10:01 PM, Andrew Lunn <andrew@lunn.ch> wrote:
> > > On Mon, May 01, 2017 at 02:45:00PM +0200, Corentin Labbe wrote:
> > >> Hello
> > >>
> > >> This patch series add the driver for dwmac-sun8i which handle the Ethernet MAC
> > >> present on Allwinner H3/H5/A83T/A64 SoCs.
> > >>
> > >> This driver is the continuation of the sun8i-emac driver.
> > >> During the development, it appeared that in fact the hardware was a modified
> > >> version of some dwmac.
> > >> So the driver is now written as a glue driver for stmmac.
> > >>
> > >> It supports 10/100/1000 Mbit/s speed with half/full duplex.
> > >> It can use an internal PHY (MII 10/100) or an external PHY
> > >> via RGMII/RMII.
> > >
> > > Hi Corentin
> > >
> > > Sorry if this has been asked before....
> > >
> > > Does the internal PHY have a phy driver? It seems like
> > > tx-delay-ps/rx-delay-ps are properties of this internal PHY, and so
> > > should be in the phy driver, if it has one.
> >
> > Nope. These affect the delay lines for the external PHY interface.
I will add some sentences in the documentation to be more clear about that.
>
> Oh, yes. I understood the patch wrong.
>
> None of the patches actually use these properties. Are they actually
> needed? We should avoid adding vendor specific properties, if they are
> not used.
>
The board that use it is the BananaPi M3, but the SoC A83T still lack clocks support.
So theses properties is already used out of tree, and will be used in tree soon.
Regards
next prev parent reply other threads:[~2017-05-01 15:59 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-01 12:45 [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet driver Corentin Labbe
2017-05-01 12:45 ` [PATCH v5 01/20] net: stmmac: export stmmac_set_mac_addr/stmmac_get_mac_addr Corentin Labbe
2017-05-01 12:45 ` [PATCH v5 02/20] net: stmmac: add optional setup function Corentin Labbe
2017-05-01 12:45 ` [PATCH v5 03/20] dt-bindings: net: Add DT bindings documentation for Allwinner dwmac-sun8i Corentin Labbe
2017-05-01 13:45 ` Andrew Lunn
2017-05-01 12:45 ` [PATCH v5 04/20] dt-bindings: syscon: Add DT bindings documentation for Allwinner syscon Corentin Labbe
2017-05-05 20:20 ` Rob Herring
2017-05-01 12:45 ` [PATCH v5 05/20] net: stmmac: Add dwmac-sun8i Corentin Labbe
2017-05-01 12:45 ` [PATCH v5 06/20] arm: sun8i: sunxi-h3-h5: Add dt node for the syscon control module Corentin Labbe
2017-05-01 12:45 ` [PATCH v5 07/20] arm: sun8i: sunxi-h3-h5: add dwmac-sun8i ethernet driver Corentin Labbe
2017-05-01 12:45 ` [PATCH v5 08/20] arm: sun8i: orangepi-pc: Enable dwmac-sun8i Corentin Labbe
2017-05-01 12:45 ` [PATCH v5 09/20] arm: sun8i: orangepi-zero: " Corentin Labbe
2017-05-01 12:45 ` [PATCH v5 10/20] arm: sun8i: orangepi-one: " Corentin Labbe
2017-05-01 12:45 ` [PATCH v5 11/20] arm: sun8i: orangepi-2: " Corentin Labbe
2017-05-01 12:45 ` [PATCH v5 12/20] arm: sun8i: orangepi-pc-plus: Set EMAC activity LEDs to active high Corentin Labbe
2017-05-01 12:45 ` [PATCH v5 13/20] arm64: allwinner: sun50i-a64: Add dt node for the syscon control module Corentin Labbe
2017-05-01 12:45 ` [PATCH v5 14/20] arm64: allwinner: sun50i-a64: add dwmac-sun8i Ethernet driver Corentin Labbe
2017-05-01 12:45 ` [PATCH v5 15/20] arm64: allwinner: pine64: Enable dwmac-sun8i Corentin Labbe
2017-05-01 12:45 ` [PATCH v5 16/20] arm64: allwinner: pine64-plus: " Corentin Labbe
2017-05-01 12:45 ` [PATCH v5 17/20] arm64: allwinner: bananapi-m64: " Corentin Labbe
2017-05-01 12:45 ` [PATCH v5 18/20] arm: sunxi: Enable dwmac-sun8i driver on sunxi_defconfig Corentin Labbe
2017-05-01 12:45 ` [PATCH v5 19/20] arm: multi_v7: Enable dwmac-sun8i driver on multi_v7_defconfig Corentin Labbe
2017-05-01 12:45 ` [PATCH v5 20/20] arm64: defconfig: Enable dwmac-sun8i driver on defconfig Corentin Labbe
2017-05-01 14:01 ` [PATCH v5 00/20] net-next: stmmac: add dwmac-sun8i ethernet driver Andrew Lunn
2017-05-01 14:28 ` Chen-Yu Tsai
2017-05-01 14:45 ` Andrew Lunn
2017-05-01 15:58 ` Corentin Labbe [this message]
2017-05-01 16:10 ` Andrew Lunn
2017-05-05 12:13 ` Corentin Labbe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170501155856.GA1957@Red \
--to=clabbe.montjoie@gmail.com \
--cc=alexandre.torgue@st.com \
--cc=andrew@lunn.ch \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).