From: Steven Rostedt <rostedt@goodmis.org>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: Vlastimil Babka <vbabka.lkml@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ingo Molnar <mingo@redhat.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
tglx@linutronix.de, peterz@infradead.org,
linux-usb@vger.kernel.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 2/5] usb: early: add driver for xhci debug capability
Date: Wed, 31 May 2017 02:24:39 -0400 [thread overview]
Message-ID: <20170531022439.54b93c69@vmware.local.home> (raw)
In-Reply-To: <592E3817.4030402@linux.intel.com>
On Wed, 31 May 2017 11:27:19 +0800
Lu Baolu <baolu.lu@linux.intel.com> wrote:
> >> +
> >> +#define XDBC_TRACE
> >> +#ifdef XDBC_TRACE
> >> +#define xdbc_trace trace_printk
> > Did you forget to remove the #define XDBC_TRACE?
> >
> > Enabling this driver brings the "trace_printk() being used.
> > Allocating extra memory. This means that this is a DEBUG kernel and
> > it is unsafe for production use." message in 4.12-rcX dmesg.
>
> This feature is only for a DEBUG kernel, should not be enabled for
> any production kernel. This was the reason I enabled trace_printk()
> by default.
Yes, it is perfectly fine to use trace_printk() for debug only configs.
But if if you have it there and it is helpful to debug something that
happens in a production system, you may want to look into creating a
real tracepoint for the locations.
-- Steve
next prev parent reply other threads:[~2017-05-31 6:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-21 8:01 [PATCH v8 0/5] usb: early: add support for early printk through USB3 debug port Lu Baolu
2017-03-21 8:01 ` [PATCH v8 1/5] x86: add simple udelay calibration Lu Baolu
2017-03-21 12:19 ` [tip:x86/debug] x86/timers: Add " tip-bot for Lu Baolu
2017-05-24 16:56 ` Jan Kiszka
2017-05-25 0:49 ` Lu Baolu
2017-05-02 22:38 ` [PATCH v8 1/5] x86: add " Boris Ostrovsky
2017-05-05 5:41 ` Lu Baolu
2017-05-05 12:50 ` Boris Ostrovsky
2017-07-12 8:02 ` Dou Liyang
2017-07-13 1:17 ` Lu Baolu
2017-07-13 1:39 ` Dou Liyang
2017-07-13 3:00 ` Lu Baolu
2017-07-14 3:21 ` Dou Liyang
2017-03-21 8:01 ` [PATCH v8 2/5] usb: early: add driver for xhci debug capability Lu Baolu
2017-03-21 12:19 ` [tip:x86/debug] usb/early: Add " tip-bot for Lu Baolu
2017-05-30 13:46 ` [PATCH v8 2/5] usb: early: add " Vlastimil Babka
2017-05-31 3:27 ` Lu Baolu
2017-05-31 6:24 ` Steven Rostedt [this message]
2017-06-01 3:35 ` Lu Baolu
2017-05-31 9:38 ` Vlastimil Babka
2017-06-01 3:37 ` Lu Baolu
2017-06-01 8:15 ` Vlastimil Babka
2017-06-01 12:25 ` Peter Zijlstra
2017-06-02 0:47 ` Steven Rostedt
2017-03-21 8:01 ` [PATCH v8 3/5] x86: add support for earlyprintk via USB3 debug port Lu Baolu
2017-03-21 12:20 ` [tip:x86/debug] x86/earlyprintk: Add " tip-bot for Lu Baolu
2017-03-21 8:01 ` [PATCH v8 4/5] usb: serial: add dbc debug device support to usb_debug Lu Baolu
2017-03-21 12:21 ` [tip:x86/debug] usb/serial: Add DBC " tip-bot for Lu Baolu
2017-03-21 8:01 ` [PATCH v8 5/5] usb: doc: add document for USB3 debug port usage Lu Baolu
2017-03-21 12:21 ` [tip:x86/debug] usb/doc: Add " tip-bot for Lu Baolu
2017-03-21 11:33 ` [PATCH v8 0/5] usb: early: add support for early printk through USB3 debug port Ingo Molnar
2017-03-21 12:27 ` Greg Kroah-Hartman
2017-03-21 12:46 ` Ingo Molnar
2017-03-22 2:23 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170531022439.54b93c69@vmware.local.home \
--to=rostedt@goodmis.org \
--cc=baolu.lu@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=vbabka.lkml@gmail.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).