From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Jiri Olsa <jolsa@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>, lkml <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Namhyung Kim <namhyung@kernel.org>,
David Ahern <dsahern@gmail.com>
Subject: Re: [PATCHv2] perf test: Disable breakpoint signal tests for powerpc
Date: Fri, 2 Jun 2017 11:05:19 -0300 [thread overview]
Message-ID: <20170602140519.GN2899@kernel.org> (raw)
In-Reply-To: <20170602140433.GM2899@kernel.org>
Em Fri, Jun 02, 2017 at 11:04:33AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Thu, Jun 01, 2017 at 10:54:50PM +0200, Jiri Olsa escreveu:
> >
> > + if (t->is_supported && !t->is_supported()) {
> > + pr_debug("%2d: %-*s: Disabled\n", i, width, t->desc);
>
> This isn't clear, I'll change this to leave the pr_debug up to the
> ->is_supported() code (that will receive the struct test pointer too),
> that can then say something more clear like what you put in that
> comment.
>
> This way, ppc hackers running 'perf test' will see that longstanding
> TODO entry ;-)
On a second thought, this can be done as a patch on top of yours, done
in perf/core, while your patch can go in perf/urgent.
- Arnaldo
> - Arnaldo
>
> > + continue;
> > + }
> > +
> > pr_info("%2d: %-*s:", i, width, t->desc);
> >
> > if (intlist__find(skiplist, i)) {
> > diff --git a/tools/perf/tests/tests.h b/tools/perf/tests/tests.h
> > index 631859629403..577363809c9b 100644
> > --- a/tools/perf/tests/tests.h
> > +++ b/tools/perf/tests/tests.h
> > @@ -34,6 +34,7 @@ struct test {
> > int (*get_nr)(void);
> > const char *(*get_desc)(int subtest);
> > } subtest;
> > + bool (*is_supported)(void);
> > };
> >
> > /* Tests */
> > @@ -99,6 +100,8 @@ const char *test__clang_subtest_get_desc(int subtest);
> > int test__clang_subtest_get_nr(void);
> > int test__unit_number__scnprint(int subtest);
> >
> > +bool test__bp_signal_is_supported(void);
> > +
> > #if defined(__arm__) || defined(__aarch64__)
> > #ifdef HAVE_DWARF_UNWIND_SUPPORT
> > struct thread;
> > --
> > 2.9.4
next prev parent reply other threads:[~2017-06-02 14:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 17:49 [PATCH] perf test: Disable breakpoint signal tests for powerpc Jiri Olsa
2017-06-01 13:04 ` Arnaldo Carvalho de Melo
2017-06-01 13:10 ` Jiri Olsa
2017-06-01 20:54 ` [PATCHv2] " Jiri Olsa
2017-06-02 14:04 ` Arnaldo Carvalho de Melo
2017-06-02 14:05 ` Arnaldo Carvalho de Melo [this message]
2017-06-02 14:31 ` Arnaldo Carvalho de Melo
2017-06-04 18:54 ` Jiri Olsa
2017-06-07 15:59 ` [tip:perf/urgent] " tip-bot for Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170602140519.GN2899@kernel.org \
--to=acme@kernel.org \
--cc=a.p.zijlstra@chello.nl \
--cc=dsahern@gmail.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).