From: Catalin Marinas <catalin.marinas@arm.com>
To: Yury Norov <ynorov@caviumnetworks.com>
Cc: linux-doc@vger.kernel.org,
Andrew Pinski <Andrew.Pinski@caviumnetworks.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Chris Metcalf <cmetcalf@ezchip.com>,
philipp.tomsich@theobroma-systems.com,
Joseph Myers <joseph@codesourcery.com>,
zhouchengming1@huawei.com,
Steve Ellcey <sellcey@caviumnetworks.com>,
Prasun.Kapoor@caviumnetworks.com, Andreas Schwab <schwab@suse.de>,
agraf@suse.de, szabolcs.nagy@arm.com, geert@linux-m68k.org,
Adam Borowski <kilobyte@angband.pl>,
manuel.montezelo@gmail.com, Chris Metcalf <cmetcalf@mellanox.com>,
Arnd Bergmann <arnd@arndb.de>, Andrew Pinski <pinskia@gmail.com>,
linyongting@huawei.com, klimov.linux@gmail.com,
broonie@kernel.org,
Bamvor Zhangjian <bamvor.zhangjian@huawei.com>,
Bamvor Jian Zhang <bamvor.zhangjian@linaro.org>,
linux-arm-kernel@lists.infradead.org,
Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>,
Florian Weimer <fweimer@redhat.com>,
Nathan_Lynch@mentor.com, linux-kernel@vger.kernel.org,
Andrew Pinski <apinski@cavium.com>,
Ramana Radhakrishnan <ramana.gcc@googlemail.com>,
schwidefsky@de.ibm.com, davem@davemloft.net,
christoph.muellner@theobroma-systems.com
Subject: Re: [PATCH 05/20] arm64: rename COMPAT to AARCH32_EL0 in Kconfig
Date: Fri, 9 Jun 2017 11:59:43 +0100 [thread overview]
Message-ID: <20170609105942.GJ2186@e104818-lin.cambridge.arm.com> (raw)
In-Reply-To: <20170608224059.fi4a5urcjoxhbgwb@yury-thinkpad>
On Fri, Jun 09, 2017 at 01:40:59AM +0300, Yury Norov wrote:
> On Thu, Jun 08, 2017 at 03:09:12PM +0100, Catalin Marinas wrote:
> > On Sun, Jun 04, 2017 at 02:59:54PM +0300, Yury Norov wrote:
> > > --- a/arch/arm64/Kconfig
> > > +++ b/arch/arm64/Kconfig
> > > @@ -402,7 +402,7 @@ config ARM64_ERRATUM_834220
> > >
> > > config ARM64_ERRATUM_845719
> > > bool "Cortex-A53: 845719: a load might read incorrect data"
> > > - depends on COMPAT
> > > + depends on AARCH32_EL0
> > > default y
> > > help
> > > This option adds an alternative code sequence to work around ARM
> > > @@ -784,7 +784,7 @@ config FORCE_MAX_ZONEORDER
> > >
> > > menuconfig ARMV8_DEPRECATED
> > > bool "Emulate deprecated/obsolete ARMv8 instructions"
> > > - depends on COMPAT
> > > + depends on AARCH32_EL0
> > > help
> > > Legacy software support may require certain instructions
> > > that have been deprecated or obsoleted in the architecture.
> > > @@ -1062,9 +1062,15 @@ menu "Userspace binary formats"
> > > source "fs/Kconfig.binfmt"
> > >
> > > config COMPAT
> > > + bool
> > > + depends on AARCH32_EL0
> >
> > You could just use "def_bool y" here
> >
> > > +
> > > +config AARCH32_EL0
> > > bool "Kernel support for 32-bit EL0"
> > > + def_bool y
> > > depends on ARM64_4K_PAGES || EXPERT
> > > select COMPAT_BINFMT_ELF if BINFMT_ELF
> > > + select COMPAT
> >
> > and avoid the explicit select.
>
> in patch 20 COMPAT becomes depending also on ARM64_ILP32, like this:
> - depends on AARCH32_EL0
> + depends on AARCH32_EL0 || ARM64_ILP32
>
> So this is a preparation for it. If it looks confusing, I think it's
> better to underline it in the description to the patch in addition to
> this:
>
> > From now, AARCH32_EL0 (former COMPAT) config option means the support of
> > AARCH32 userspace, ARM64_ILP32 - support of ILP32 ABI (see next patches),
> > and COMPAT indicates that one of them, or both, is enabled.
>
> But if you prefer, I can do like you suggested here and make COMPAT
> depend on AARCH32_EL0 in the last patch.
What I meant is that if you define COMPAT as "def_bool y", you no longer
need the explicit "select COMPAT". When AARCH32_EL0 is disabled, COMPAT
would automatically be disabled because of the "depends on AARCH32_EL0"
line.
--
Catalin
next prev parent reply other threads:[~2017-06-09 10:59 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-04 11:59 Yury Norov
2017-06-04 11:59 ` [PATCH 01/20] compat ABI: use non-compat openat and open_by_handle_at variants Yury Norov
2017-06-04 11:59 ` [PATCH 02/20] 32-bit ABI: introduce ARCH_32BIT_OFF_T config option Yury Norov
2017-06-08 15:09 ` Catalin Marinas
2017-06-13 11:04 ` Yury Norov
2017-06-14 12:31 ` Catalin Marinas
2017-06-04 11:59 ` [PATCH 03/20] asm-generic: Drop getrlimit and setrlimit syscalls from default list Yury Norov
2017-06-05 14:44 ` James Hogan
2017-06-07 18:48 ` Yury Norov
2017-06-04 11:59 ` [PATCH 04/20] arm64: ilp32: add documentation on the ILP32 ABI for ARM64 Yury Norov
2017-06-04 11:59 ` [PATCH 05/20] arm64: rename COMPAT to AARCH32_EL0 in Kconfig Yury Norov
2017-06-08 14:09 ` Catalin Marinas
2017-06-08 22:40 ` Yury Norov
2017-06-09 10:59 ` Catalin Marinas [this message]
2017-06-19 15:58 ` James Morse
2017-06-20 23:10 ` Yury Norov
2017-06-22 11:45 ` Yury Norov
2017-06-04 11:59 ` [PATCH 06/20] arm64: ensure the kernel is compiled for LP64 Yury Norov
2017-06-04 11:59 ` [PATCH 07/20] arm64:uapi: set __BITS_PER_LONG correctly for ILP32 and LP64 Yury Norov
2017-06-04 11:59 ` [PATCH 08/20] thread: move thread bits accessors to separated file Yury Norov
2017-06-04 11:59 ` [PATCH 09/20] arm64: introduce is_a32_task and is_a32_thread (for AArch32 compat) Yury Norov
2017-06-04 11:59 ` [PATCH 10/20] arm64: ilp32: add is_ilp32_compat_{task,thread} and TIF_32BIT_AARCH64 Yury Norov
2017-06-04 12:00 ` [PATCH 11/20] arm64: introduce binfmt_elf32.c Yury Norov
2017-06-04 12:00 ` [PATCH 12/20] arm64: ilp32: introduce binfmt_ilp32.c Yury Norov
2017-06-04 12:00 ` [PATCH 13/20] arm64: ilp32: share aarch32 syscall handlers Yury Norov
2017-06-08 14:10 ` Catalin Marinas
2017-06-08 14:28 ` Arnd Bergmann
2017-06-04 12:00 ` [PATCH 14/20] arm64: ilp32: add sys_ilp32.c and a separate table (in entry.S) to use it Yury Norov
2017-06-08 15:05 ` James Morse
2017-06-09 7:06 ` Yury Norov
2017-06-04 12:00 ` [PATCH 15/20] arm64: signal: share lp64 signal routines to ilp32 Yury Norov
2017-06-04 12:00 ` [PATCH 16/20] arm64: signal32: move ilp32 and aarch32 common code to separated file Yury Norov
2017-06-19 16:16 ` James Morse
2017-06-20 14:16 ` Yury Norov
2017-06-04 12:00 ` [PATCH 17/20] arm64: ilp32: introduce ilp32-specific handlers for sigframe and ucontext Yury Norov
2017-06-04 12:00 ` [PATCH 18/20] arm64: ptrace: handle ptrace_request differently for aarch32 and ilp32 Yury Norov
2017-06-23 17:03 ` James Morse
2017-06-23 22:28 ` Yury Norov
2017-06-27 10:12 ` James Morse
2017-06-04 12:00 ` [PATCH 19/20] arm64:ilp32: add vdso-ilp32 and use for signal return Yury Norov
2017-06-08 15:24 ` Catalin Marinas
2017-06-08 23:06 ` Yury Norov
2017-06-04 12:00 ` [PATCH 20/20] arm64:ilp32: add ARM64_ILP32 to Kconfig Yury Norov
2017-06-14 20:16 ` your mail Yury Norov
-- strict thread matches above, loose matches on Subject: below --
2017-06-19 15:49 [PATCH v8 00/20] ILP32 for ARM64 Yury Norov
2017-06-19 15:49 ` [PATCH 05/20] arm64: rename COMPAT to AARCH32_EL0 in Kconfig Yury Norov
2017-03-01 19:19 [PATCH v7 resend 00/20] ILP32 for ARM64 Yury Norov
2017-03-01 19:19 ` [PATCH 05/20] arm64: rename COMPAT to AARCH32_EL0 in Kconfig Yury Norov
2017-01-09 11:29 [PATCH v7 00/20] ILP32 for ARM64 Yury Norov
2017-01-09 11:29 ` [PATCH 05/20] arm64: rename COMPAT to AARCH32_EL0 in Kconfig Yury Norov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170609105942.GJ2186@e104818-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=Andrew.Pinski@caviumnetworks.com \
--cc=Nathan_Lynch@mentor.com \
--cc=Prasun.Kapoor@caviumnetworks.com \
--cc=agraf@suse.de \
--cc=apinski@cavium.com \
--cc=arnd@arndb.de \
--cc=bamvor.zhangjian@huawei.com \
--cc=bamvor.zhangjian@linaro.org \
--cc=broonie@kernel.org \
--cc=christoph.muellner@theobroma-systems.com \
--cc=cmetcalf@ezchip.com \
--cc=cmetcalf@mellanox.com \
--cc=davem@davemloft.net \
--cc=fweimer@redhat.com \
--cc=geert@linux-m68k.org \
--cc=heiko.carstens@de.ibm.com \
--cc=joseph@codesourcery.com \
--cc=kilobyte@angband.pl \
--cc=klimov.linux@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linyongting@huawei.com \
--cc=manuel.montezelo@gmail.com \
--cc=maxim.kuvyrkov@linaro.org \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=pinskia@gmail.com \
--cc=ramana.gcc@googlemail.com \
--cc=schwab@suse.de \
--cc=schwidefsky@de.ibm.com \
--cc=sellcey@caviumnetworks.com \
--cc=szabolcs.nagy@arm.com \
--cc=ynorov@caviumnetworks.com \
--cc=zhouchengming1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).