From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752835AbdFTWWM (ORCPT ); Tue, 20 Jun 2017 18:22:12 -0400 Received: from smtprelay0018.hostedemail.com ([216.40.44.18]:59091 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752401AbdFTWWL (ORCPT ); Tue, 20 Jun 2017 18:22:11 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1540:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4250:5007:6261:7875:7903:10004:10400:10848:10967:11026:11232:11658:11914:12296:12740:12760:12895:13069:13311:13357:13439:14181:14659:14721:21080:21451:21627:30054:30070:30090:30091,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:,MSBL:0,DNSBL:none,Custom_rules:0:0:0,LFtime:2,LUA_SUMMARY:none X-HE-Tag: park13_2fe760ab20432 X-Filterd-Recvd-Size: 2248 Date: Tue, 20 Jun 2017 18:22:05 -0400 From: Steven Rostedt To: Tejun Heo Cc: Andrew Morton , Christoph Lameter , Pekka Enberg , LKML , Linus Torvalds , Vladimir Davydov , David Rientjes , Joonsoo Kim Subject: Re: [PATCH] slub: make sysfs file removal asynchronous Message-ID: <20170620182205.6e0390d8@grimm.local.home> In-Reply-To: <20170620220011.GJ21326@htj.duckdns.org> References: <20170616085507.3cc7d4b8@gandalf.local.home> <20170619203538.GN12062@htj.duckdns.org> <20170619172750.6890df32@gandalf.local.home> <20170620204512.GI21326@htj.duckdns.org> <20170620145814.9eb1b74feaf908c39e9c0de2@linux-foundation.org> <20170620220011.GJ21326@htj.duckdns.org> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 20 Jun 2017 18:00:11 -0400 Tejun Heo wrote: > > > Signed-off-by: Tejun Heo > > > Reported-by: Steven Rostedt (VMware) > > > Tested-by: Steven Rostedt (VMware) > > > Fixes: bf5eb3de3847 ("slub: separate out sysfs_slab_release() from sysfs_slab_remove()") > > > > Do you think we should add cc:stable [4.11+]? > > I think we'd risk more by backporting it through -stable than keeping > the bug there. The bug is very difficult to hit. Famous last words. > Writing to a slub > sysfs file has to race against kmem_cache destruction and AFAICS all > slub sysfs files are for debugging. It's not that big of a change. It's simply moving the work to a work queue. I've done bigger changes than this and backported it to stable for similar reasons. All it takes is for it to be hit once in a billion, and that billionth time could be critical. -- Steve