From: Baoquan He <bhe@redhat.com>
To: Joerg Roedel <jroedel@suse.de>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
root <root@amd-dinar-02.lab.bos.redhat.com>
Subject: Re: [PATCH v8 13/13] iommu/amd: Disable iommu only if amd_iommu=off is specified
Date: Fri, 28 Jul 2017 17:08:34 +0800 [thread overview]
Message-ID: <20170728090834.GO24304@x1> (raw)
In-Reply-To: <20170727155852.GQ3610@suse.de>
On 07/27/17 at 05:58pm, Joerg Roedel wrote:
> On Fri, Jul 21, 2017 at 04:59:11PM +0800, Baoquan He wrote:
> > From: root <root@amd-dinar-02.lab.bos.redhat.com>
>
> You probaly need to reset the author on this one.
Oops, sorry. I made this patch on a testing machine. Will correct it.
Thanks a lot for all these comments and great suggestions.
>
> >
> > It's ok to disable iommu in normal kernel. While there's no need
> > to disable it in kdump kernel after the on-flight dma issue has
> > heen fixed.
> >
> > Signed-off-by: Baoquan He <bhe@redhat.com>
> > ---
> > drivers/iommu/amd_iommu_init.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c
> > index 8b4bac978062..880f693c809b 100644
> > --- a/drivers/iommu/amd_iommu_init.c
> > +++ b/drivers/iommu/amd_iommu_init.c
> > @@ -2494,7 +2494,8 @@ static int __init early_amd_iommu_init(void)
> > goto out;
> >
> > /* Disable any previously enabled IOMMUs */
> > - disable_iommus();
> > + if (amd_iommu_disabled)
> > + disable_iommus();
> >
> > if (amd_iommu_irq_remap)
> > amd_iommu_irq_remap = check_ioapic_information();
> > --
> > 2.5.5
prev parent reply other threads:[~2017-07-28 9:08 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-21 8:58 [PATCH v8 00/13] Fix the on-flight DMA issue on system with amd iommu Baoquan He
2017-07-21 8:58 ` [PATCH v8 01/13] iommu/amd: Detect pre enabled translation Baoquan He
2017-07-27 15:04 ` Joerg Roedel
2017-07-28 2:31 ` Baoquan He
2017-07-21 8:59 ` [PATCH v8 02/13] iommu/amd: add several helper functions Baoquan He
2017-07-27 15:06 ` Joerg Roedel
2017-07-28 2:36 ` Baoquan He
2017-07-31 10:01 ` Baoquan He
2017-07-31 10:07 ` Joerg Roedel
2017-07-21 8:59 ` [PATCH v8 03/13] Revert "iommu/amd: Suppress IO_PAGE_FAULTs in kdump kernel" Baoquan He
2017-07-21 8:59 ` [PATCH v8 04/13] iommu/amd: Define bit fields for DTE particularly Baoquan He
2017-07-21 8:59 ` [PATCH v8 05/13] iommu/amd: Add function copy_dev_tables() Baoquan He
2017-07-27 15:29 ` Joerg Roedel
2017-07-28 3:59 ` Baoquan He
2017-07-21 8:59 ` [PATCH v8 06/13] iommu/amd: copy old trans table from old kernel Baoquan He
2017-07-27 15:38 ` Joerg Roedel
2017-07-28 6:52 ` Baoquan He
2017-07-21 8:59 ` [PATCH v8 07/13] iommu/amd: Do sanity check for irq remap of old dev table entry Baoquan He
2017-07-21 8:59 ` [PATCH v8 08/13] iommu: Add is_attach_deferred call-back to iommu-ops Baoquan He
2017-07-21 8:59 ` [PATCH v8 09/13] iommu/amd: Use is_attach_deferred call-back Baoquan He
2017-07-27 15:53 ` Joerg Roedel
2017-07-28 4:02 ` Baoquan He
2017-07-21 8:59 ` [PATCH v8 10/13] iommu/amd: Allocate memory below 4G for dev table if translation pre-enabled Baoquan He
2017-07-27 15:55 ` Joerg Roedel
2017-07-28 9:06 ` Baoquan He
2017-07-28 11:14 ` Joerg Roedel
2017-07-28 11:15 ` Baoquan He
2017-07-28 11:18 ` Joerg Roedel
2017-07-28 11:26 ` Baoquan He
2017-07-31 10:15 ` Baoquan He
2017-07-31 10:21 ` Joerg Roedel
2017-07-31 10:29 ` Baoquan He
2017-07-21 8:59 ` [PATCH v8 11/13] iommu/amd: Don't copy GCR3 table root pointer Baoquan He
2017-07-23 22:33 ` kbuild test robot
2017-07-23 23:53 ` Baoquan He
2017-07-27 15:57 ` Joerg Roedel
2017-07-28 9:07 ` Baoquan He
2017-07-21 8:59 ` [PATCH v8 12/13] iommu/amd: Clear out the GV flag when handle deferred domain attach Baoquan He
2017-07-21 8:59 ` [PATCH v8 13/13] iommu/amd: Disable iommu only if amd_iommu=off is specified Baoquan He
2017-07-27 15:58 ` Joerg Roedel
2017-07-28 9:08 ` Baoquan He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170728090834.GO24304@x1 \
--to=bhe@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jroedel@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=root@amd-dinar-02.lab.bos.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).