From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Linux-Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Subject: Re: linux-next: Tree for Aug 1
Date: Tue, 1 Aug 2017 21:42:04 +0900 [thread overview]
Message-ID: <20170801124204.GA457@jagdpanzerIV.localdomain> (raw)
In-Reply-To: <20170801173746.6962444d@canb.auug.org.au>
Hello,
seems that commit 979990c6284814617 ("tty: improve tty_insert_flip_char()
fast path") panics my kernel.
in particular, this part
@@ -26,7 +27,7 @@ static inline int tty_insert_flip_char(struct tty_port *port,
*char_buf_ptr(tb, tb->used++) = ch;
return 1;
}
- return tty_insert_flip_string_flags(port, &ch, &flag, 1);
+ return __tty_insert_flip_char(port, ch, flag);
}
I see various callstacks, but all endup in llist_del_first() -> fatal exception
in interrupt -> panic()
...
uart_insert_char()
__tty_insert_flip_char()
__tty_buffer_request_room()
llist_del_first()
or
...
kdb_event()
puts_queue()
__tty_insert_flip_char()
__tty_buffer_request_room()
llist_del_first()
to reproduce:
1) screen /dev/ttyS0 115200
2) send several chars down to /dev/ttyS0, enough to panic() the kernel.
reverting that __tty_insert_flip_char(port, ch, flag) seems to work
on my side.
-ss
next prev parent reply other threads:[~2017-08-01 12:42 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 7:37 linux-next: Tree for Aug 1 Stephen Rothwell
2017-08-01 12:42 ` Sergey Senozhatsky [this message]
2017-08-01 13:20 ` Arnd Bergmann
2017-08-01 13:28 ` Arnd Bergmann
2017-08-01 23:55 ` Sergey Senozhatsky
2017-08-02 11:13 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2023-08-01 5:19 Stephen Rothwell
2019-08-01 6:14 Stephen Rothwell
2018-08-01 7:58 Stephen Rothwell
2018-08-01 22:48 ` Guenter Roeck
2018-08-01 22:52 ` James Bottomley
2018-08-01 23:00 ` James Bottomley
2018-08-02 0:05 ` Stephen Rothwell
2018-08-02 1:19 ` Guenter Roeck
2018-08-01 23:47 ` Guenter Roeck
2018-08-01 23:57 ` Ming Lei
2018-08-02 0:03 ` James Bottomley
2018-08-02 0:20 ` Guenter Roeck
2018-08-02 4:58 ` Guenter Roeck
2018-08-02 5:04 ` Bart Van Assche
2018-08-02 12:46 ` Guenter Roeck
2018-08-02 12:51 ` Johannes Thumshirn
2018-08-02 13:00 ` Guenter Roeck
2018-08-02 13:06 ` Johannes Thumshirn
2018-08-02 11:35 ` Ming Lei
2018-08-02 13:05 ` Guenter Roeck
2018-08-02 16:27 ` Ming Lei
2018-08-02 16:40 ` Bart Van Assche
2018-08-02 16:50 ` Ming Lei
2018-08-02 16:57 ` Bart Van Assche
2018-08-02 0:12 ` Guenter Roeck
2016-08-01 4:02 Stephen Rothwell
2014-08-01 9:14 Stephen Rothwell
2013-08-01 7:25 Stephen Rothwell
2013-08-01 7:50 ` Sedat Dilek
2011-08-01 4:47 Stephen Rothwell
2011-08-01 7:01 ` Sedat Dilek
2011-08-01 21:54 ` Randy Dunlap
2011-08-02 1:29 ` Stephen Rothwell
2011-08-02 10:38 ` Sedat Dilek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170801124204.GA457@jagdpanzerIV.localdomain \
--to=sergey.senozhatsky.work@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=sergey.senozhatsky@gmail.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).