From: Davidlohr Bueso <dave@stgolabs.net>
To: Andrea Parri <parri.andrea@gmail.com>
Cc: Prateek Sood <prsood@codeaurora.org>,
mingo@kernel.org, longman@redhat.com, peterz@infradead.org,
linux-kernel@vger.kernel.org, sramana@codeaurora.org
Subject: Re: [PATCH] rwsem: fix missed wakeup due to reordering of load
Date: Wed, 27 Sep 2017 14:20:12 -0700 [thread overview]
Message-ID: <20170927212012.GA26599@linux-80c1.suse> (raw)
In-Reply-To: <20170920211727.GA26082@andrea>
On Wed, 20 Sep 2017, Andrea Parri wrote:
>> Instead, how about just removing the release from atomic_long_sub_return_release()
>> such that the osq load is not hoisted over the atomic compound (along with Peter's
>> comment):
>
>This solution will actually enforce a stronger (full) ordering w.r.t. the
>solution described by Prateek and Peter. Also, it will "trade" two lwsync
>for two sync (powerpc), one dmb.ld for one dmb (arm64).
>
>What are the reasons you would prefer this?
It was mainly to maintain consistency about dealing with sem->count, but sure
I won't argue with the above.
next prev parent reply other threads:[~2017-09-27 21:20 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-07 14:30 [PATCH] rwsem: fix missed wakeup due to reordering of load Prateek Sood
2017-09-19 14:05 ` Andrea Parri
2017-09-20 14:52 ` Davidlohr Bueso
2017-09-20 21:17 ` Andrea Parri
2017-09-27 21:20 ` Davidlohr Bueso [this message]
2017-09-26 18:37 ` Prateek Sood
2017-09-29 9:30 ` [tip:locking/urgent] locking/rwsem-xadd: Fix " tip-bot for Prateek Sood
-- strict thread matches above, loose matches on Subject: below --
2017-08-23 11:28 [PATCH] rwsem: fix " Prateek Sood
2017-08-24 11:29 ` Peter Zijlstra
2017-08-24 12:33 ` Peter Zijlstra
2017-08-24 12:52 ` Peter Zijlstra
2017-09-07 14:08 ` Prateek Sood
2017-07-26 20:17 Prateek Sood
2017-07-27 15:48 ` Waiman Long
2017-07-27 16:59 ` Peter Zijlstra
2017-08-10 8:32 ` Andrea Parri
2017-08-10 10:41 ` Peter Zijlstra
2017-08-10 10:44 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170927212012.GA26599@linux-80c1.suse \
--to=dave@stgolabs.net \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@kernel.org \
--cc=parri.andrea@gmail.com \
--cc=peterz@infradead.org \
--cc=prsood@codeaurora.org \
--cc=sramana@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).