linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
	Jens Axboe <axboe@fb.com>,
	tglx@linutronix.de
Subject: Re: [PATCH 1/2] sched/rt: Add a helper to test for a RT task
Date: Fri, 6 Oct 2017 10:19:37 +0200	[thread overview]
Message-ID: <20171006081937.eshxl36hitrd4j22@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20171004154901.26904-1-bigeasy@linutronix.de>

On Wed, Oct 04, 2017 at 05:49:00PM +0200, Sebastian Andrzej Siewior wrote:
> This helper returns true if a task has elevated priority which is true
> for RT tasks (SCHED_RR and SCHED_FIFO) and also for SCHED_DEADLINE.
> A task which runs at RT priority due to PI-boosting is not considered as
> one with elevated priority.
> 
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> ---
>  include/linux/sched/rt.h | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/include/linux/sched/rt.h b/include/linux/sched/rt.h
> index f93329aba31a..30a86b8178f8 100644
> --- a/include/linux/sched/rt.h
> +++ b/include/linux/sched/rt.h
> @@ -17,6 +17,17 @@ static inline int rt_task(struct task_struct *p)
>  	return rt_prio(p->prio);
>  }
>  
> +static inline bool task_is_elevated(struct task_struct *tsk)

Would you be terribly upset if I rename that? I'm thinking something
like task_is_realtime() better reflects what it does.

> +{
> +	int policy = tsk->policy;
> +
> +	if (policy == SCHED_FIFO || policy == SCHED_RR)
> +		return true;
> +	if (policy == SCHED_DEADLINE)
> +		return true;
> +	return false;
> +}
> +
>  #ifdef CONFIG_RT_MUTEXES
>  /*
>   * Must hold either p->pi_lock or task_rq(p)->lock.
> -- 
> 2.14.2
> 

  parent reply	other threads:[~2017-10-06  8:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-04 15:49 [PATCH 1/2] sched/rt: Add a helper to test for a RT task Sebastian Andrzej Siewior
2017-10-04 15:49 ` [PATCH 2/2] block/ioprio: use a helper to check for RT prio Sebastian Andrzej Siewior
2017-10-10 11:01   ` [tip:sched/core] block/ioprio: Use " tip-bot for Sebastian Andrzej Siewior
2017-10-06  8:19 ` Peter Zijlstra [this message]
2017-10-06  8:51   ` [PATCH 1/2] sched/rt: Add a helper to test for a RT task Sebastian Andrzej Siewior
2017-10-10 11:01 ` [tip:sched/core] " tip-bot for Sebastian Andrzej Siewior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171006081937.eshxl36hitrd4j22@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=axboe@fb.com \
    --cc=bigeasy@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).