From: Jan Kara <jack@suse.cz>
To: Arnd Bergmann <arnd@arndb.de>
Cc: y2038@lists.linaro.org, Jan Kara <jack@suse.cz>,
Al Viro <viro@zeniv.linux.org.uk>,
Deepa Dinamani <deepa.kernel@gmail.com>,
linux-fsdevel@vger.kernel.org, Anders Larsen <al@alarsen.net>,
stable@vger.kernel.org, David Howells <dhowells@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] isofs: fix timestamps beyond 2027
Date: Thu, 19 Oct 2017 17:17:37 +0200 [thread overview]
Message-ID: <20171019151737.GC17891@quack2.suse.cz> (raw)
In-Reply-To: <20171019144811.2144678-1-arnd@arndb.de>
On Thu 19-10-17 16:47:48, Arnd Bergmann wrote:
> isofs uses a 'char' variable to load the number of years since
> 1900 for an inode timestamp. On architectures that use a signed
> char type by default, this results in an invalid date for
> anything beyond 2027.
>
> This changes the function argument to a 'u8' array, which
> is defined the same way on all architectures, and unambiguously
> lets us use years until 2155.
>
> This should be backported to all kernels that might still be
> in use by that date.
>
> Cc: stable@vger.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
...
> -int iso_date(char * p, int flag)
> +int iso_date(u8 *p, int flag)
> {
> int year, month, day, hour, minute, second, tz;
> int crtime;
>
> - year = p[0];
> + year = (int)(u8)p[0];
The cast seems unnecessary now?
Honza
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2017-10-19 15:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-19 14:47 [PATCH v2 1/2] isofs: fix timestamps beyond 2027 Arnd Bergmann
2017-10-19 14:47 ` [PATCH v2 2/2] isofs: use unsigned char types consistently Arnd Bergmann
2017-10-31 17:11 ` Jan Kara
2017-10-19 15:17 ` Jan Kara [this message]
2017-10-19 15:29 ` [PATCH v2 1/2] isofs: fix timestamps beyond 2027 Arnd Bergmann
2017-10-31 16:59 ` Jan Kara
2017-10-31 21:36 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171019151737.GC17891@quack2.suse.cz \
--to=jack@suse.cz \
--cc=al@alarsen.net \
--cc=arnd@arndb.de \
--cc=deepa.kernel@gmail.com \
--cc=dhowells@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=y2038@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).