linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Andreas Bombe" <aeb@debian.org>, "Karel Zak" <kzak@redhat.com>,
	util-linux@vger.kernel.org,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Andrius Štikonas" <andrius@stikonas.eu>,
	"Curtis Gedak" <gedakc@gmail.com>
Subject: Re: Linux & FAT32 label
Date: Sun, 5 Nov 2017 14:39:29 +0100	[thread overview]
Message-ID: <20171105133929.7cscboxymmpkw634@pali> (raw)
In-Reply-To: <CAHp75VdWXHtCHiRxnbAidr9inehVC=av6gp7-jtJqN6WPYh4fg@mail.gmail.com>

On Tuesday 31 October 2017 10:35:48 Andy Shevchenko wrote:
> On Mon, Oct 16, 2017 at 4:12 AM, Andreas Bombe <aeb@debian.org> wrote:
> > On Thu, Oct 12, 2017 at 10:49:31PM +0200, Pali Rohár wrote:
> >> On Thursday 12 October 2017 12:13:11 Karel Zak wrote:
> >> > On Thu, Oct 12, 2017 at 11:21:13AM +0200, Pali Rohár wrote:
> >> > > > The best for me is to keep blkid output backwardly compatible as much
> >> > > > as possible :-)
> >> > >
> >> > > Backward compatibility is a good reason. But what with situation when
> >> > > interoperability with other systems (e.g. Windows) does not work as
> >> > > expected?
> >> >
> >> > Then... I'm ready to do the changes to keep interoperability with the
> >> > rest of the universe. It's the same situation as with UDF, you know...
> >>
> >> Apparently situation is not same as with UDF. For UDF we have
> >> specification and basically all known UDF implementation by me were
> >> compatible how to treat label except blkid (which read different think).
> >>
> >> For FAT32 we have 3 different linux implementations (blkid, fatlabel,
> >> mlabel) and every one is slightly different in reading label (see
> >> results sent in previous emails).
> >>
> >> What is first needed to know if implementations are willing to change to
> >> be more or less same. And then decide what we want to change.
> >>
> >> Andreas, as fatlabel maintainer, what do you think about it?
> >>
> >> If you want, I can prepare patches for blkid and fatlabel to mimic
> >> behavior written in proposed solution. But I think it does not make
> >> sense to change just one Linux tool...
> >
> > I was worried that there might be some scripts or programs that expect
> 
> If we really care about such scripts another approach might be to
> introduce a CLI switch to "spec compatible mode" to each tool and
> suggest in documentation to use it.
> 
> There are also variants:
> - spec compatible
> - WinXX compatible
> - DOS compatible
> - etc

I did tests with MS-DOS and Windows versions (results in previous
email), and they seems to be compatible how they read label.

Based on results I would suggest to ignore label from the boot sector
when reading label. This makes behavior consistent with older MS-DOS
systems and also all Windows systems. This change would be a problem
only for users who have label stored only in boot sector. After change
they would not see label anymore -- exactly same what MS-DOS or Windows
show them. Seems that mkdosfs stores label to both location, since
support for label was introduced. So different label would be visible
only for users who used dosfslabel prior to version 3.0.16.

What do you think?

-- 
Pali Rohár
pali.rohar@gmail.com

  reply	other threads:[~2017-11-05 13:39 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-04 15:33 Linux & FAT32 label Pali Rohár
2017-10-11 21:24 ` Pali Rohár
2017-10-11 21:29   ` Pali Rohár
2017-10-11 21:44   ` Pali Rohár
2017-10-12  8:56     ` Karel Zak
2017-10-12  9:21       ` Pali Rohár
2017-10-12 10:13         ` Karel Zak
2017-10-12 20:49           ` Pali Rohár
2017-10-16  1:12             ` Andreas Bombe
2017-10-16  7:28               ` Pali Rohár
2017-10-30 15:29                 ` Pali Rohár
2017-10-31  8:35               ` Andy Shevchenko
2017-11-05 13:39                 ` Pali Rohár [this message]
2017-11-05 13:56                   ` Andy Shevchenko
2017-11-05 14:07                     ` Pali Rohár
2017-11-05 14:25                       ` Andy Shevchenko
2017-11-05 14:34                         ` Pali Rohár
2017-11-05 14:51                           ` Andy Shevchenko
2017-11-05 14:56                             ` Pali Rohár
2017-11-06 10:14                           ` Karel Zak
2017-11-09  8:59                             ` Pali Rohár
2017-11-09 11:02                               ` Karel Zak
2017-11-05 20:35                       ` Theodore Ts'o
2017-11-05 21:12                         ` Pali Rohár
2017-11-07 17:28                           ` Theodore Ts'o
2017-11-09  9:01                             ` Pali Rohár
2017-11-09 16:21                               ` Theodore Ts'o
2017-11-09 17:33                                 ` Pali Rohár
2017-11-05 14:12                     ` Andrius Štikonas
2017-10-15  6:59     ` Pavel Machek
2017-10-15 22:04       ` Pali Rohár
2017-10-16  1:12         ` Andreas Bombe
2017-11-05 13:06   ` Pali Rohár
2017-11-09 21:21     ` Pali Rohár
2017-11-19 12:44       ` Pali Rohár
2017-11-20 11:12         ` Karel Zak
2017-11-22  8:52           ` Pali Rohár
2017-11-22 11:03             ` Karel Zak
2017-11-22 14:29               ` Andrius Štikonas
2017-11-23  9:01               ` Pali Rohár
2017-11-26 19:19           ` Pali Rohár
2017-11-27 12:13             ` Karel Zak
2018-02-14 21:52               ` Pali Rohár
2018-02-14 21:54                 ` Pali Rohár
2018-02-15 10:21                   ` Karel Zak
2018-03-07  8:28               ` Pali Rohár
2017-11-29 23:21           ` Pali Rohár
2018-01-29 16:49             ` Pali Rohár
2017-12-16 22:45       ` Pali Rohár

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171105133929.7cscboxymmpkw634@pali \
    --to=pali.rohar@gmail.com \
    --cc=aeb@debian.org \
    --cc=andrius@stikonas.eu \
    --cc=andy.shevchenko@gmail.com \
    --cc=gedakc@gmail.com \
    --cc=kzak@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=util-linux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).